This is an automated email from the ASF dual-hosted git repository.

rexxiong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 7263f64f2 [CELEBORN-1126] Set kubernetes resources field for master 
and worker init container for helm chart
7263f64f2 is described below

commit 7263f64f234627a50d911575cb2d7a089a62c14d
Author: Marwan Salem <[email protected]>
AuthorDate: Tue Nov 14 11:48:43 2023 +0800

    [CELEBORN-1126] Set kubernetes resources field for master and worker init 
container for helm chart
    
    ### What changes were proposed in this pull request?
    For the `helm` chart. I specified the resources field for the 
`initContainers` for `worker` and `master` statefulsets.
    I used the same values which are specified for the "main" container
    
    ### Why are the changes needed?
    For users that have a `ResourceQuota` (such as myself), worker and master 
pods do not start since the initContainers for the statefulsets do not specify 
the resources (cpu/ memory requests and limits).
    
    ### Does this PR introduce _any_ user-facing change?
    
    ### [Issue](https://github.com/apache/incubator-celeborn/issues/2094)
    
    ### How was this patch tested?
    I installed the chart on my GKE cluster.
    
    Closes #2093 from marwansalem/set-k8s-resources-for-init-containers.
    
    Authored-by: Marwan Salem <[email protected]>
    Signed-off-by: Shuang <[email protected]>
---
 charts/celeborn/templates/master-statefulset.yaml | 2 ++
 charts/celeborn/templates/worker-statefulset.yaml | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/charts/celeborn/templates/master-statefulset.yaml 
b/charts/celeborn/templates/master-statefulset.yaml
index fbd101929..e988783f5 100644
--- a/charts/celeborn/templates/master-statefulset.yaml
+++ b/charts/celeborn/templates/master-statefulset.yaml
@@ -88,6 +88,8 @@ spec:
         - chown
         - {{ .Values.securityContext.runAsUser | default 10006 }}:{{ 
.Values.securityContext.runAsGroup | default 10006 }}
         - {{ (index $dirs 0).mountPath }}
+        resources:
+          {{- toYaml .Values.resources.master | nindent 12 }}
         volumeMounts:
           - name: {{ $.Release.Name }}-master-vol-0
             mountPath: {{ (index $dirs 0).mountPath }}
diff --git a/charts/celeborn/templates/worker-statefulset.yaml 
b/charts/celeborn/templates/worker-statefulset.yaml
index 11efd50de..a9a003adc 100644
--- a/charts/celeborn/templates/worker-statefulset.yaml
+++ b/charts/celeborn/templates/worker-statefulset.yaml
@@ -90,6 +90,8 @@ spec:
         {{- range $dir := $dirs }}
         - {{ $dir.mountPath }}
         {{- end}}
+        resources:
+          {{- toYaml .Values.resources.worker | nindent 12 }}
         volumeMounts:
         {{- range $index, $dir := $dirs }}
         - name: {{ $.Release.Name }}-worker-vol-{{ $index }}

Reply via email to