(incubator-celeborn) branch branch-0.3 updated: [CELEBORN-1162][BUG] Fix refCnt 0 Exception in FetchHandler#handleChunkFetchRequest

[ethanfeng]

This is an automated email from the ASF dual-hosted git repository.

ethanfeng pushed a commit to branch branch-0.3
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/branch-0.3 by this push:
     new ed7213cdf [CELEBORN-1162][BUG] Fix refCnt 0 Exception in 
FetchHandler#handleChunkFetchRequest
ed7213cdf is described below

commit ed7213cdf42f8801cd16376616695e40deef0af0
Author: zky.zhoukeyong <zky.zhoukey...@alibaba-inc.com>
AuthorDate: Tue Dec 12 16:40:08 2023 +0800

    [CELEBORN-1162][BUG] Fix refCnt 0 Exception in 
FetchHandler#handleChunkFetchRequest
---
 .../org/apache/celeborn/service/deploy/worker/FetchHandler.scala   | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/FetchHandler.scala
 
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/FetchHandler.scala
index 5a6a3e774..ad17d923e 100644
--- 
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/FetchHandler.scala
+++ 
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/FetchHandler.scala
@@ -341,7 +341,8 @@ class FetchHandler(
       }
     }
 
-    workerSource.startTimer(WorkerSource.FETCH_CHUNK_TIME, req.toString)
+    val reqStr = req.toString
+    workerSource.startTimer(WorkerSource.FETCH_CHUNK_TIME, reqStr)
     val fetchTimeMetric = 
chunkStreamManager.getFetchTimeMetric(req.streamChunkSlice.streamId)
     val fetchBeginTime = System.nanoTime()
     try {
@@ -368,7 +369,7 @@ class FetchHandler(
             if (fetchTimeMetric != null) {
               fetchTimeMetric.update(System.nanoTime() - fetchBeginTime)
             }
-            workerSource.stopTimer(WorkerSource.FETCH_CHUNK_TIME, req.toString)
+            workerSource.stopTimer(WorkerSource.FETCH_CHUNK_TIME, reqStr)
           }
         })
     } catch {
@@ -380,7 +381,7 @@ class FetchHandler(
         client.getChannel.writeAndFlush(new ChunkFetchFailure(
           req.streamChunkSlice,
           Throwables.getStackTraceAsString(e)))
-        workerSource.stopTimer(WorkerSource.FETCH_CHUNK_TIME, req.toString)
+        workerSource.stopTimer(WorkerSource.FETCH_CHUNK_TIME, reqStr)
     }
   }