This is an automated email from the ASF dual-hosted git repository.

fchen pushed a commit to branch branch-0.4
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/branch-0.4 by this push:
     new 316fa767f [CELEBORN-1216] Resolve error occurring during distribution 
creation with profile `-Pspark-2.4`
316fa767f is described below

commit 316fa767f67d0c1ed814db859fa84d83d9123fad
Author: Fu Chen <[email protected]>
AuthorDate: Tue Jan 9 23:40:09 2024 +0800

    [CELEBORN-1216] Resolve error occurring during distribution creation with 
profile `-Pspark-2.4`
    
    ### What changes were proposed in this pull request?
    
    As title
    
    ### Why are the changes needed?
    
    ```
    $ ./build/make-distribution.sh --sbt-enabled -Pspark-2.4
    ...
    cp: 
/Users/fchen/Project/incubator-celeborn/master/target/scala-2.12/celeborn-master_2.12-0.5.0-SNAPSHOT.jar:
 No such file or directory
    ```
    
    The SBT will derive the scala version from the spark project when the spark 
profile is specified.
    
    This PR eliminates the user-specified profile, ensuring that the `copyJars` 
task aligns with the `package` task in terms of the scala version.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    
    Local test
    
    Closes #2218 from cfmcgrady/fix-spark24.
    
    Authored-by: Fu Chen <[email protected]>
    Signed-off-by: Fu Chen <[email protected]>
    (cherry picked from commit daddd2d2c1e0485ab0ca6651fb6f77bf5f113089)
    Signed-off-by: Fu Chen <[email protected]>
---
 build/make-distribution.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build/make-distribution.sh b/build/make-distribution.sh
index 7aa4fc9c2..b063942ca 100755
--- a/build/make-distribution.sh
+++ b/build/make-distribution.sh
@@ -257,7 +257,7 @@ function sbt_build_service {
   echo "Celeborn $VERSION$GITREVSTRING" > "$DIST_DIR/RELEASE"
   echo "Build flags: $@" >> "$DIST_DIR/RELEASE"
 
-  BUILD_COMMAND=("$SBT" clean package $@)
+  BUILD_COMMAND=("$SBT" clean package)
 
   # Actually build the jar
   echo -e "\nBuilding with..."

Reply via email to