This is an automated email from the ASF dual-hosted git repository.

zhouky pushed a commit to branch branch-0.4
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/branch-0.4 by this push:
     new bd01ff3c3 [CELEBORN-1247][FOLLOWUP] Remove inexistent configs
bd01ff3c3 is described below

commit bd01ff3c3644588b9f07c72cbe0edf3e8f729692
Author: mingji <[email protected]>
AuthorDate: Thu Jan 25 10:20:21 2024 +0800

    [CELEBORN-1247][FOLLOWUP] Remove inexistent configs
    
    ### What changes were proposed in this pull request?
    Fix docs error merged from main.
    
    ### Why are the changes needed?
    
    ### Does this PR introduce _any_ user-facing change?
    NO.
    
    ### How was this patch tested?
    GA.
    
    Closes #2263 from FMX/b1247-1.
    
    Authored-by: mingji <[email protected]>
    Signed-off-by: zky.zhoukeyong <[email protected]>
---
 common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala | 2 +-
 docs/configuration/client.md                                        | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala 
b/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
index b707f5b29..51266165d 100644
--- a/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
+++ b/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
@@ -1356,7 +1356,7 @@ object CelebornConf extends Logging {
     buildConf("celeborn.network.memory.allocator.verbose.metric")
       .categories("network")
       .version("0.3.0")
-      .doc("Weather to enable verbose metric for pooled allocator.")
+      .doc("Whether to enable verbose metric for pooled allocator.")
       .booleanConf
       .createWithDefault(false)
 
diff --git a/docs/configuration/client.md b/docs/configuration/client.md
index 284edf157..ba4863150 100644
--- a/docs/configuration/client.md
+++ b/docs/configuration/client.md
@@ -102,13 +102,11 @@ license: |
 | celeborn.client.shuffle.register.filterExcludedWorker.enabled | false | 
Whether to filter excluded worker when register shuffle. | 0.4.0 |  | 
 | celeborn.client.slot.assign.maxWorkers | 10000 | Max workers that slots of 
one shuffle can be allocated on. Will choose the smaller positive one from 
Master side and Client side, see `celeborn.master.slot.assign.maxWorkers`. | 
0.3.1 |  | 
 | celeborn.client.spark.fetch.throwsFetchFailure | false | client throws 
FetchFailedException instead of CelebornIOException | 0.4.0 |  | 
-| celeborn.client.spark.push.dynamicWriteMode.enabled | false | Whether to 
dynamically switch push write mode based on conditions.If true, shuffle mode 
will be only determined by partition count | 0.5.0 |  | 
-| celeborn.client.spark.push.dynamicWriteMode.partitionNum.threshold | 2000 | 
Threshold of shuffle partition number for dynamically switching push writer 
mode. When the shuffle partition number is greater than this value, use the 
sort-based shuffle writer for memory efficiency; otherwise use the hash-based 
shuffle writer for speed. This configuration only takes effect when 
celeborn.client.spark.push.dynamicWriteMode.enabled is true. | 0.5.0 |  | 
 | celeborn.client.spark.push.sort.memory.threshold | 64m | When 
SortBasedPusher use memory over the threshold, will trigger push data. | 0.3.0 
| celeborn.push.sortMemory.threshold | 
 | celeborn.client.spark.push.unsafeRow.fastWrite.enabled | true | This is 
Celeborn's optimization on UnsafeRow for Spark and it's true by default. If you 
have changed UnsafeRow's memory layout set this to false. | 0.2.2 |  | 
 | celeborn.client.spark.shuffle.forceFallback.enabled | false | Whether force 
fallback shuffle to Spark's default. | 0.3.0 | 
celeborn.shuffle.forceFallback.enabled | 
 | celeborn.client.spark.shuffle.forceFallback.numPartitionsThreshold | 
2147483647 | Celeborn will only accept shuffle of partition number lower than 
this configuration value. | 0.3.0 | 
celeborn.shuffle.forceFallback.numPartitionsThreshold | 
-| celeborn.client.spark.shuffle.writer | HASH | Celeborn supports the 
following kind of shuffle writers. 1. hash: hash-based shuffle writer works 
fine when shuffle partition count is normal; 2. sort: sort-based shuffle writer 
works fine when memory pressure is high or shuffle partition count is huge. 
This configuration only takes effect when 
celeborn.client.spark.push.dynamicWriteMode.enabled is false. | 0.3.0 | 
celeborn.shuffle.writer | 
+| celeborn.client.spark.shuffle.writer | HASH | Celeborn supports the 
following kind of shuffle writers. 1. hash: hash-based shuffle writer works 
fine when shuffle partition count is normal; 2. sort: sort-based shuffle writer 
works fine when memory pressure is high or shuffle partition count is huge. | 
0.3.0 | celeborn.shuffle.writer | 
 | celeborn.master.endpoints | &lt;localhost&gt;:9097 | Endpoints of master 
nodes for celeborn client to connect, allowed pattern is: 
`<host1>:<port1>[,<host2>:<port2>]*`, e.g. `clb1:9097,clb2:9098,clb3:9099`. If 
the port is omitted, 9097 will be used. | 0.2.0 |  | 
 | celeborn.storage.availableTypes | HDD | Enabled storages. Available options: 
MEMORY,HDD,SSD,HDFS. Note: HDD and SSD would be treated as identical. | 0.3.0 | 
celeborn.storage.activeTypes | 
 | celeborn.storage.hdfs.dir | &lt;undefined&gt; | HDFS base directory for 
Celeborn to store shuffle data. | 0.2.0 |  | 

Reply via email to