This is an automated email from the ASF dual-hosted git repository.

nicholasjiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 2a89c3011 [CELEBORN-1244] Delete redundant remove operations and 
handle timeout requests in final check
2a89c3011 is described below

commit 2a89c3011bed056fc6153eea5191c563980855fe
Author: jiaoqingbo <[email protected]>
AuthorDate: Mon Feb 5 13:57:52 2024 +0800

    [CELEBORN-1244] Delete redundant remove operations and handle timeout 
requests in final check
    
    ### What changes were proposed in this pull request?
    Delete redundant remove operations and handle timeout requests in final 
check
    
    ### Why are the changes needed?
    
    Delete redundant remove operations and handle timeout requests in final 
check
    
    ### Does this PR introduce _any_ user-facing change?
    
    NO
    
    ### How was this patch tested?
    
    PASS GA
    
    Closes #2251 from jiaoqingbo/CELEBORN-1244.
    
    Authored-by: jiaoqingbo <[email protected]>
    Signed-off-by: SteNicholas <[email protected]>
---
 .../src/main/scala/org/apache/celeborn/client/commit/CommitHandler.scala | 1 -
 1 file changed, 1 deletion(-)

diff --git 
a/client/src/main/scala/org/apache/celeborn/client/commit/CommitHandler.scala 
b/client/src/main/scala/org/apache/celeborn/client/commit/CommitHandler.scala
index 632d407da..59cf44641 100644
--- 
a/client/src/main/scala/org/apache/celeborn/client/commit/CommitHandler.scala
+++ 
b/client/src/main/scala/org/apache/celeborn/client/commit/CommitHandler.scala
@@ -357,7 +357,6 @@ abstract class CommitHandler(
             logError(
               s"Ask worker($worker) CommitFiles for $shuffleId failed because 
of Timeout" +
                 s" (attempt ${status.retriedTimes}/$maxRetries), will not 
retry.")
-            iter.remove()
           }
         }
       }

Reply via email to