This is an automated email from the ASF dual-hosted git repository.

ethanfeng pushed a commit to branch branch-0.4
in repository https://gitbox.apache.org/repos/asf/celeborn.git


The following commit(s) were added to refs/heads/branch-0.4 by this push:
     new ee96396b4 [CELEBORN-1407] Change log4j2 template appender to file
ee96396b4 is described below

commit ee96396b40dff74de2852fa4feb4812ebc102cd5
Author: mingji <[email protected]>
AuthorDate: Mon May 6 16:12:35 2024 +0800

    [CELEBORN-1407] Change log4j2 template appender to file
    
    ### What changes were proposed in this pull request?
    Rotate redirected stdout logs to make sure that logs won't consume too much 
disk space.
    
    ### Why are the changes needed?
    1. Stdout appender might cause log files too large.
    2. Output logs to stdout if there is no log4j2 configs.
    
    ### Does this PR introduce _any_ user-facing change?
    Stdout logs behavior is reserved.
    
    ### How was this patch tested?
    GA.
    
    Closes #2486 from FMX/b1407.
    
    Authored-by: mingji <[email protected]>
    Signed-off-by: mingji <[email protected]>
    (cherry picked from commit f895343b49f187ed4285c459089ed2135632b831)
    Signed-off-by: mingji <[email protected]>
---
 conf/log4j2.xml.template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/conf/log4j2.xml.template b/conf/log4j2.xml.template
index 687951922..5f78b4e23 100644
--- a/conf/log4j2.xml.template
+++ b/conf/log4j2.xml.template
@@ -42,8 +42,8 @@
                 <Delete basePath="${env:CELEBORN_LOG_DIR}" maxDepth="1">
                     <IfFileName glob="celeborn.log*">
                         <IfAny>
-                            <IfAccumulatedFileSize exceeds="1 GB" />
-                            <IfAccumulatedFileCount exceeds="10" />
+                            <IfAccumulatedFileSize exceeds="1 GB"/>
+                            <IfAccumulatedFileCount exceeds="10"/>
                         </IfAny>
                     </IfFileName>
                 </Delete>
@@ -56,16 +56,16 @@
             <!--
               ~ Here are appender templates, keep the appender as your need.
               -->
-            <AppenderRef ref="stdout"/>
+            <!-- <AppenderRef ref="stdout"/>-->
             <AppenderRef ref="file"/>
         </Root>
         <Logger name="org.apache.hadoop.hdfs" level="WARN" additivity="false">
-            <Appender-ref ref="stdout" level="WARN" />
+            <!-- <Appender-ref ref="stdout" level="WARN"/>-->
             <Appender-ref ref="file" level="WARN"/>
         </Logger>
         <Logger name="org.apache.ratis.server.RaftServerConfigKeys" 
level="WARN" additivity="false">
-             <Appender-ref ref="stdout" level="WARN" />
-             <Appender-ref ref="file" level="WARN"/>
+            <!-- <Appender-ref ref="stdout" level="WARN"/>-->
+            <Appender-ref ref="file" level="WARN"/>
         </Logger>
     </Loggers>
 </Configuration>

Reply via email to