This is an automated email from the ASF dual-hosted git repository.
ethanfeng pushed a commit to branch branch-0.5
in repository https://gitbox.apache.org/repos/asf/celeborn.git
The following commit(s) were added to refs/heads/branch-0.5 by this push:
new 20c730f0f [CELEBORN-1455] Remove improper configs from config template
20c730f0f is described below
commit 20c730f0f6ff5287f7e3ce83a0a2c1884ca05249
Author: mingji <[email protected]>
AuthorDate: Tue Jun 11 15:35:53 2024 +0800
[CELEBORN-1455] Remove improper configs from config template
### What changes were proposed in this pull request?
To remove improper default configs.
### Why are the changes needed?
Many users won't change default configs in the template causing bad
performance in test scenarios.
### Does this PR introduce _any_ user-facing change?
NO.
### How was this patch tested?
GA.
Closes #2550 from FMX/b1455.
Authored-by: mingji <[email protected]>
Signed-off-by: mingji <[email protected]>
(cherry picked from commit 3e875d0177b47d5e6ffb0720006ade99bf764f09)
Signed-off-by: mingji <[email protected]>
---
conf/celeborn-defaults.conf.template | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/conf/celeborn-defaults.conf.template
b/conf/celeborn-defaults.conf.template
index 8a9312047..7656fdf99 100644
--- a/conf/celeborn-defaults.conf.template
+++ b/conf/celeborn-defaults.conf.template
@@ -16,17 +16,10 @@
#
# An Example:
-celeborn.rpc.io.mode NIO
-celeborn.rpc.io.clientThreads 8
-celeborn.rpc.io.serverThreads 8
-celeborn.rpc.io.numConnectionsPerPeer 2
-
-celeborn.push.io.numConnectionsPerPeer 2
-celeborn.worker.push.io.threads 8
+# celeborn.worker.storage.dirs
/mnt/disk1:capacity=1T:disktype=HDD:flushthread=1,/mnt/disk2:capacity=1T:disktype=SSD:flushthread=16
celeborn.metrics.enabled true
-celeborn.worker.storage.dirs
/mnt/disk1,/mnt/disk2,/mnt/disk3,/mnt/disk4,/mnt/disk5
celeborn.worker.http.port 9096
celeborn.master.endpoints
clb-1:9097,clb-2:9097,clb-3:9097
@@ -43,5 +36,3 @@ celeborn.master.ha.node.3.host clb-3
celeborn.master.ha.node.3.port 9097
celeborn.master.ha.node.3.ratis.port 9872
celeborn.master.ha.ratis.raft.server.storage.dir
/mnt/disk1/celeborn_ratis/
-celeborn.master.ha.ratis.raft.server.snapshot.auto.trigger.enabled true
-celeborn.master.ha.ratis.raft.server.snapshot.auto.trigger.threshold
200000