This is an automated email from the ASF dual-hosted git repository.
nicholasjiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git
The following commit(s) were added to refs/heads/main by this push:
new d0563ea1c [CELEBORN-1478] Fix wrong use partitionId as shuffleId when
readPartition
d0563ea1c is described below
commit d0563ea1c09c2f3ae51648021d5a8fedae50ee4f
Author: Shuang <[email protected]>
AuthorDate: Mon Jun 24 11:44:06 2024 +0800
[CELEBORN-1478] Fix wrong use partitionId as shuffleId when readPartition
### What changes were proposed in this pull request?
Change partitionId to shuffleId
### Why are the changes needed?
As title, Although the partitionId is used as the shuffleId when reading a
partition, it has no effect on the final result
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
PASS GA
Closes #2589 from RexXiong/CELEBORN-1478.
Authored-by: Shuang <[email protected]>
Signed-off-by: SteNicholas <[email protected]>
---
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java
b/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java
index 345caecdb..f68086448 100644
--- a/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java
+++ b/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java
@@ -1679,7 +1679,7 @@ public class ShuffleClientImpl extends ShuffleClient {
int[] mapAttempts,
MetricsCallback metricsCallback)
throws IOException {
- if (partitionId == Utils$.MODULE$.UNKNOWN_APP_SHUFFLE_ID()) {
+ if (shuffleId == Utils$.MODULE$.UNKNOWN_APP_SHUFFLE_ID()) {
logger.warn("Shuffle data is empty for shuffle {}:
UNKNOWN_APP_SHUFFLE_ID.", shuffleId);
return CelebornInputStream.empty();
}
