This is an automated email from the ASF dual-hosted git repository.
nicholasjiang pushed a commit to branch branch-0.4
in repository https://gitbox.apache.org/repos/asf/celeborn.git
The following commit(s) were added to refs/heads/branch-0.4 by this push:
new 706dda743 [CELEBORN-1578] Make Worker#timer have thread name and daemon
706dda743 is described below
commit 706dda743a17f3011a715c2e57ed827cb9fb0113
Author: sychen <[email protected]>
AuthorDate: Thu Aug 29 02:18:46 2024 +0800
[CELEBORN-1578] Make Worker#timer have thread name and daemon
### What changes were proposed in this pull request?
### Why are the changes needed?
Current jstack
```java
"pool-36-thread-1" #118 prio=5 os_prio=0 tid=0x00007f40cc00d000 nid=0xd3e0
waiting on condition [0x00007f3ecbffe000]
java.lang.Thread.State: TIMED_WAITING (sleeping)
at java.lang.Thread.sleep(Native Method)
at
io.netty.util.HashedWheelTimer$Worker.waitForNextTick(HashedWheelTimer.java:600)
at
io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:496)
at java.lang.Thread.run(Thread.java:745)
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
GA
Closes #2704 from cxzl25/CELEBORN-1578.
Lead-authored-by: sychen <[email protected]>
Co-authored-by: cxzl25 <[email protected]>
Signed-off-by: SteNicholas <[email protected]>
(cherry picked from commit 5c839656f6f51b8920b37caa51c2c6e96e139af4)
Signed-off-by: SteNicholas <[email protected]>
---
.../main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
index 873c91f37..4b9e6fa43 100644
---
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
+++
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
@@ -259,7 +259,7 @@ private[celeborn] class Worker(
conf.workerCleanThreads)
val asyncReplyPool: ScheduledExecutorService =
ThreadUtils.newDaemonSingleThreadScheduledExecutor("worker-rpc-async-replier")
- val timer = new HashedWheelTimer()
+ val timer = new
HashedWheelTimer(ThreadUtils.namedSingleThreadFactory("worker-timer"))
// Configs
private val heartbeatInterval = conf.workerHeartbeatTimeout / 4
