This is an automated email from the ASF dual-hosted git repository.

rexxiong pushed a commit to branch branch-0.5
in repository https://gitbox.apache.org/repos/asf/celeborn.git


The following commit(s) were added to refs/heads/branch-0.5 by this push:
     new cdf9a33b9 [CELEBORN-1865] Update master endpointRef when master leader 
is abnormal
cdf9a33b9 is described below

commit cdf9a33b9a0b13237d7936577408d3a5c8932c78
Author: zhengtao <[email protected]>
AuthorDate: Thu Feb 20 10:26:11 2025 +0800

    [CELEBORN-1865] Update master endpointRef when master leader is abnormal
    
    ### What changes were proposed in this pull request?
    `rpcEndpointRef` should be set to `null` When master leader is not present.
    
    ### Why are the changes needed?
    Attempt master address index can only be updated when `rpcEndpointRef` is 
`null`.
    
    The index wont update  if `rpcEndpointRef` has been set but some error 
ocurs to the master leader.
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    
    Closes #3101 from zaynt4606/clb1865.
    
    Authored-by: zhengtao <[email protected]>
    Signed-off-by: Shuang <[email protected]>
    (cherry picked from commit 27c6605c4a6b192ef946439c287487932b72cff1)
    Signed-off-by: Shuang <[email protected]>
---
 common/src/main/java/org/apache/celeborn/common/client/MasterClient.java | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/common/src/main/java/org/apache/celeborn/common/client/MasterClient.java 
b/common/src/main/java/org/apache/celeborn/common/client/MasterClient.java
index 8cb9bd02c..480df2df2 100644
--- a/common/src/main/java/org/apache/celeborn/common/client/MasterClient.java
+++ b/common/src/main/java/org/apache/celeborn/common/client/MasterClient.java
@@ -181,6 +181,7 @@ public class MasterClient {
         setRpcEndpointRef(leaderAddr);
       } else {
         LOG.warn("Master leader is not present currently, please check 
masters' status!");
+        resetRpcEndpointRef(oldRef);
       }
       return true;
     } else if (e.getCause() instanceof IOException || e instanceof 
RpcTimeoutException) {

Reply via email to