(celeborn) branch branch-0.5 updated: [CELEBORN-1897] Avoid calling toString for too long messages

[nicholasjiang]

This is an automated email from the ASF dual-hosted git repository.

nicholasjiang pushed a commit to branch branch-0.5
in repository https://gitbox.apache.org/repos/asf/celeborn.git


The following commit(s) were added to refs/heads/branch-0.5 by this push:
     new 43fd3eec2 [CELEBORN-1897] Avoid calling toString for too long messages
43fd3eec2 is described below

commit 43fd3eec28dc522320e3bc13091e6f89e459f072
Author: CodingCat <zhunans...@gmail.com>
AuthorDate: Mon Mar 10 11:33:13 2025 +0800

    [CELEBORN-1897] Avoid calling toString for too long messages
    
    ### What changes were proposed in this pull request?
    
    
https://github.com/apache/celeborn/blob/196ad607cd62af83b1ace887b8eb91d548fc36ac/common/src/main/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnv.scala#L256
 we hit the issue that the ignored message is too long , and when calling 
toString, it applies for a too large array which is beyond the JVM's limit 
    
    I don't think this log convey too much info, , so we could avoid calling 
toString to improve robustness of the applications
    
    ### Why are the changes needed?
    
    more details in JIRA
    
    ### Does this PR introduce _any_ user-facing change?
    
    no
    
    ### How was this patch tested?
    
    prod
    
    Closes #3139 from CodingCat/log.
    
    Authored-by: CodingCat <zhunans...@gmail.com>
    Signed-off-by: SteNicholas <programg...@163.com>
    (cherry picked from commit 18b268d08590e800920c5b8674797353945ab6ee)
    Signed-off-by: SteNicholas <programg...@163.com>
---
 .../main/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnv.scala   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/common/src/main/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnv.scala 
b/common/src/main/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnv.scala
index 67732620d..87630d547 100644
--- 
a/common/src/main/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnv.scala
+++ 
b/common/src/main/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnv.scala
@@ -251,7 +251,7 @@ class NettyRpcEnv(
       case RpcFailure(e) => onFailure(e)
       case rpcReply =>
         if (!promise.trySuccess(rpcReply)) {
-          logWarning(s"Ignored message: $reply")
+          logWarning(s"Ignored message: ${reply.getClass.getCanonicalName}")
         }
     }