This is an automated email from the ASF dual-hosted git repository.

nicholasjiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 5a50686ef [CELEBORN-2020][FOLLOWUP] Fix CLI master commands 
authentication testing
5a50686ef is described below

commit 5a50686ef63818bfad11916055dd4e2f186f9b6b
Author: Wang, Fei <[email protected]>
AuthorDate: Tue Jun 3 20:32:43 2025 +0800

    [CELEBORN-2020][FOLLOWUP] Fix CLI master commands authentication testing
    
    ### What changes were proposed in this pull request?
    
    Fix the remaining master sub commands that does not transfer auth header.
    
    ### Why are the changes needed?
    
    Before, this mistake was not detected by GA.
    
    Because the authentication configs was not trasnferred when setting mini 
celeborn cluster.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    UT.
    
    Closes #3303 from turboFei/auth_header_followup.
    
    Authored-by: Wang, Fei <[email protected]>
    Signed-off-by: 子懿 <[email protected]>
---
 .../scala/org/apache/celeborn/cli/master/MasterSubcommandImpl.scala | 3 ++-
 .../scala/org/apache/celeborn/cli/TestCelebornCliCommands.scala     | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git 
a/cli/src/main/scala/org/apache/celeborn/cli/master/MasterSubcommandImpl.scala 
b/cli/src/main/scala/org/apache/celeborn/cli/master/MasterSubcommandImpl.scala
index 5f0e288b2..c32b95bbc 100644
--- 
a/cli/src/main/scala/org/apache/celeborn/cli/master/MasterSubcommandImpl.scala
+++ 
b/cli/src/main/scala/org/apache/celeborn/cli/master/MasterSubcommandImpl.scala
@@ -113,7 +113,8 @@ class MasterSubcommandImpl extends Runnable with 
MasterSubcommand {
     workerApi.sendWorkerEvent(sendWorkerEventRequest, 
commonOptions.getAuthHeader)
   }
 
-  private[master] def runShowWorkerEventInfo: WorkerEventsResponse = 
workerApi.getWorkerEvents
+  private[master] def runShowWorkerEventInfo: WorkerEventsResponse =
+    workerApi.getWorkerEvents(commonOptions.getAuthHeader)
 
   private[master] def runShowLostWorkers: Seq[WorkerTimestampData] = {
     val lostWorkers = runShowWorkers.getLostWorkers.asScala.toSeq
diff --git 
a/cli/src/test/scala/org/apache/celeborn/cli/TestCelebornCliCommands.scala 
b/cli/src/test/scala/org/apache/celeborn/cli/TestCelebornCliCommands.scala
index eaee31beb..e47d8cec7 100644
--- a/cli/src/test/scala/org/apache/celeborn/cli/TestCelebornCliCommands.scala
+++ b/cli/src/test/scala/org/apache/celeborn/cli/TestCelebornCliCommands.scala
@@ -56,8 +56,10 @@ class TestCelebornCliCommands extends CelebornFunSuite with 
MiniClusterFeature {
 
   override def beforeAll(): Unit = {
     logInfo("test initialized, setup celeborn mini cluster")
-    val (m, w) =
-      setupMiniClusterWithRandomPorts(workerConf = celebornConf.getAll.toMap, 
workerNum = 1)
+    val (m, w) = setupMiniClusterWithRandomPorts(
+      masterConf = celebornConf.getAll.toMap,
+      workerConf = celebornConf.getAll.toMap,
+      workerNum = 1)
     master = m
     worker = w.head
     super.beforeAll()

Reply via email to