This is an automated email from the ASF dual-hosted git repository.

nicholasjiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 979f2e214 [CELEBORN-2073] Fix PartitionFileSizeBytes metrics
979f2e214 is described below

commit 979f2e2148e53eab36398a08c66a6be57f00027e
Author: Wang, Fei <[email protected]>
AuthorDate: Mon Jul 21 14:25:06 2025 +0800

    [CELEBORN-2073] Fix PartitionFileSizeBytes metrics
    
    ### What changes were proposed in this pull request?
    
    This PR fix two issues:
    
    1. followup https://github.com/apache/celeborn/pull/3047, the metrics 
positions for `PartitionFileSizeBytes` on grafana dashboard are wrong.
    2. follow up https://github.com/apache/celeborn/pull/3085, 
PartitionFileSizeBytes does not work.
    
    ### Why are the changes needed?
    
    1. The metrics positions are not correct, they should be placed under 
`Worker` row. But now, they are at the end.
    <img width="1727" height="247" alt="image" 
src="https://github.com/user-attachments/assets/87a7eb1d-e296-4730-8986-efbf48aa35e6";
 />
    
    2. the metrics does not work after 
https://github.com/apache/celeborn/commit/951b626a9896759a9ce09add39358ffd08d78496#diff-93aed69b393af59cefdfa6f5293f4dfb9cba96a9be23f3eec0bbe7d61f6d65be
    <img width="2072" height="282" alt="image" 
src="https://github.com/user-attachments/assets/28d0b404-914a-49e5-ac71-f399b3c3d44a";
 />
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    
    1. the metrics position looks good now.
    <img width="1703" height="534" alt="image" 
src="https://github.com/user-attachments/assets/f5b78d37-9d84-4241-9285-e9a2ba0b12b2";
 />
    
    2. UT
    
    Closes #3374 from turboFei/fix_metrics_pos.
    
    Authored-by: Wang, Fei <[email protected]>
    Signed-off-by: SteNicholas <[email protected]>
---
 assets/grafana/celeborn-dashboard.json             | 385 +++++++++++----------
 .../deploy/worker/storage/PartitionDataWriter.java |   9 +-
 .../deploy/worker/storage/StorageManager.scala     |   1 +
 .../local/DiskMapPartitionDataWriterSuiteJ.java    |   7 +
 .../local/DiskReducePartitionDataWriterSuiteJ.java |  13 +
 .../MemoryReducePartitionDataWriterSuiteJ.java     |  14 +
 6 files changed, 237 insertions(+), 192 deletions(-)

diff --git a/assets/grafana/celeborn-dashboard.json 
b/assets/grafana/celeborn-dashboard.json
index 261948b91..0ef2cc795 100644
--- a/assets/grafana/celeborn-dashboard.json
+++ b/assets/grafana/celeborn-dashboard.json
@@ -3417,7 +3417,7 @@
             "type": "prometheus",
             "uid": "${DS_PROMETHEUS}"
           },
-          "description": "size of partition files in bytes",
+          "description": "mean size of partition files in bytes",
           "fieldConfig": {
             "defaults": {
               "color": {
@@ -3469,7 +3469,8 @@
                     "value": 80
                   }
                 ]
-              }
+              },
+              "unit": "decbytes"
             },
             "overrides": []
           },
@@ -3507,15 +3508,15 @@
               "refId": "A"
             }
           ],
-          "title": "metrics_ PartitionFileSizeBytes_Mean",
+          "title": "metrics_PartitionFileSizeBytes_Mean",
           "type": "timeseries"
         },
         {
           "datasource": {
-            "default": false,
             "type": "prometheus",
             "uid": "${DS_PROMETHEUS}"
           },
+          "description": "p99 size of partition files in size",
           "fieldConfig": {
             "defaults": {
               "color": {
@@ -3567,7 +3568,8 @@
                     "value": 80
                   }
                 ]
-              }
+              },
+              "unit": "decbytes"
             },
             "overrides": []
           },
@@ -3575,9 +3577,9 @@
             "h": 8,
             "w": 12,
             "x": 0,
-            "y": 70
+            "y": 118
           },
-          "id": 238,
+          "id": 236,
           "options": {
             "legend": {
               "calcs": [],
@@ -3596,215 +3598,216 @@
                 "type": "prometheus",
                 "uid": "${DS_PROMETHEUS}"
               },
-              "editorMode": "builder",
-              "expr": 
"metrics_UnreleasedPartitionLocationCount_Value{role=\"Worker\", 
instance=~\"${instance}\"}",
+              "editorMode": "code",
+              "expr": 
"metrics_PartitionFileSizeBytes_99thPercentile{role=\"Worker\", 
instance=~\"${instance}\"}",
+              "hide": false,
               "instant": false,
+              "legendFormat": "${baseLegend}",
               "range": true,
               "refId": "A"
             }
           ],
-          "title": "metrics_UnreleasedPartitionLocationCount_Value",
+          "title": "metrics_PartitionFileSizeBytes_99thPercentile",
           "type": "timeseries"
-        }
-      ],
-      "title": "Worker",
-      "type": "row"
-    },
-    {
-      "datasource": {
-        "type": "prometheus",
-        "uid": "${DS_PROMETHEUS}"
-      },
-      "description": "p99 size of partition files in size",
-      "fieldConfig": {
-        "defaults": {
-          "color": {
-            "mode": "palette-classic"
-          },
-          "custom": {
-            "axisBorderShow": false,
-            "axisCenteredZero": false,
-            "axisColorMode": "text",
-            "axisLabel": "",
-            "axisPlacement": "auto",
-            "barAlignment": 0,
-            "barWidthFactor": 0.6,
-            "drawStyle": "line",
-            "fillOpacity": 0,
-            "gradientMode": "none",
-            "hideFrom": {
-              "legend": false,
-              "tooltip": false,
-              "viz": false
-            },
-            "insertNulls": false,
-            "lineInterpolation": "linear",
-            "lineWidth": 1,
-            "pointSize": 5,
-            "scaleDistribution": {
-              "type": "linear"
-            },
-            "showPoints": "auto",
-            "spanNulls": false,
-            "stacking": {
-              "group": "A",
-              "mode": "none"
-            },
-            "thresholdsStyle": {
-              "mode": "off"
-            }
-          },
-          "mappings": [],
-          "thresholds": {
-            "mode": "absolute",
-            "steps": [
-              {
-                "color": "green",
-                "value": null
-              },
-              {
-                "color": "red",
-                "value": 80
-              }
-            ]
-          }
-        },
-        "overrides": []
-      },
-      "gridPos": {
-        "h": 8,
-        "w": 12,
-        "x": 0,
-        "y": 70
-      },
-      "id": 236,
-      "options": {
-        "legend": {
-          "calcs": [],
-          "displayMode": "list",
-          "placement": "bottom",
-          "showLegend": true
         },
-        "tooltip": {
-          "mode": "single",
-          "sort": "none"
-        }
-      },
-      "targets": [
         {
           "datasource": {
             "type": "prometheus",
             "uid": "${DS_PROMETHEUS}"
           },
-          "editorMode": "code",
-          "expr": 
"metrics_PartitionFileSizeBytes_99thPercentile{role=\"Worker\", 
instance=~\"${instance}\"}",
-          "hide": false,
-          "instant": false,
-          "legendFormat": "${baseLegend}",
-          "range": true,
-          "refId": "A"
-        }
-      ],
-      "title": "metrics_ PartitionFileSizeBytes_99thPercentile",
-      "type": "timeseries"
-    },
-    {
-      "datasource": {
-        "type": "prometheus",
-        "uid": "${DS_PROMETHEUS}"
-      },
-      "description": "max size of partition files in size",
-      "fieldConfig": {
-        "defaults": {
-          "color": {
-            "mode": "palette-classic"
-          },
-          "custom": {
-            "axisBorderShow": false,
-            "axisCenteredZero": false,
-            "axisColorMode": "text",
-            "axisLabel": "",
-            "axisPlacement": "auto",
-            "barAlignment": 0,
-            "barWidthFactor": 0.6,
-            "drawStyle": "line",
-            "fillOpacity": 0,
-            "gradientMode": "none",
-            "hideFrom": {
-              "legend": false,
-              "tooltip": false,
-              "viz": false
-            },
-            "insertNulls": false,
-            "lineInterpolation": "linear",
-            "lineWidth": 1,
-            "pointSize": 5,
-            "scaleDistribution": {
-              "type": "linear"
+          "description": "max size of partition files in size",
+          "fieldConfig": {
+            "defaults": {
+              "color": {
+                "mode": "palette-classic"
+              },
+              "custom": {
+                "axisBorderShow": false,
+                "axisCenteredZero": false,
+                "axisColorMode": "text",
+                "axisLabel": "",
+                "axisPlacement": "auto",
+                "barAlignment": 0,
+                "barWidthFactor": 0.6,
+                "drawStyle": "line",
+                "fillOpacity": 0,
+                "gradientMode": "none",
+                "hideFrom": {
+                  "legend": false,
+                  "tooltip": false,
+                  "viz": false
+                },
+                "insertNulls": false,
+                "lineInterpolation": "linear",
+                "lineWidth": 1,
+                "pointSize": 5,
+                "scaleDistribution": {
+                  "type": "linear"
+                },
+                "showPoints": "auto",
+                "spanNulls": false,
+                "stacking": {
+                  "group": "A",
+                  "mode": "none"
+                },
+                "thresholdsStyle": {
+                  "mode": "off"
+                }
+              },
+              "mappings": [],
+              "thresholds": {
+                "mode": "absolute",
+                "steps": [
+                  {
+                    "color": "green",
+                    "value": null
+                  },
+                  {
+                    "color": "red",
+                    "value": 80
+                  }
+                ]
+              },
+              "unit": "decbytes"
             },
-            "showPoints": "auto",
-            "spanNulls": false,
-            "stacking": {
-              "group": "A",
-              "mode": "none"
+            "overrides": []
+          },
+          "gridPos": {
+            "h": 8,
+            "w": 12,
+            "x": 12,
+            "y": 118
+          },
+          "id": 237,
+          "options": {
+            "legend": {
+              "calcs": [],
+              "displayMode": "list",
+              "placement": "bottom",
+              "showLegend": true
             },
-            "thresholdsStyle": {
-              "mode": "off"
+            "tooltip": {
+              "mode": "single",
+              "sort": "none"
             }
           },
-          "mappings": [],
-          "thresholds": {
-            "mode": "absolute",
-            "steps": [
-              {
-                "color": "green",
-                "value": null
+          "targets": [
+            {
+              "datasource": {
+                "type": "prometheus",
+                "uid": "${DS_PROMETHEUS}"
               },
-              {
-                "color": "red",
-                "value": 80
-              }
-            ]
-          }
-        },
-        "overrides": []
-      },
-      "gridPos": {
-        "h": 8,
-        "w": 12,
-        "x": 12,
-        "y": 110
-      },
-      "id": 237,
-      "options": {
-        "legend": {
-          "calcs": [],
-          "displayMode": "list",
-          "placement": "bottom",
-          "showLegend": true
+              "editorMode": "code",
+              "expr": "metrics_PartitionFileSizeBytes_Max{role=\"Worker\", 
instance=~\"${instance}\"}",
+              "hide": false,
+              "instant": false,
+              "legendFormat": "${baseLegend}",
+              "range": true,
+              "refId": "A"
+            }
+          ],
+          "title": "metrics_PartitionFileSizeBytes_Max",
+          "type": "timeseries"
         },
-        "tooltip": {
-          "mode": "single",
-          "sort": "none"
-        }
-      },
-      "targets": [
         {
           "datasource": {
+            "default": false,
             "type": "prometheus",
             "uid": "${DS_PROMETHEUS}"
           },
-          "editorMode": "code",
-          "expr": "metrics_PartitionFileSizeBytes_Max{role=\"Worker\", 
instance=~\"${instance}\"}",
-          "hide": false,
-          "instant": false,
-          "legendFormat": "${baseLegend}",
-          "range": true,
-          "refId": "A"
+          "fieldConfig": {
+            "defaults": {
+              "color": {
+                "mode": "palette-classic"
+              },
+              "custom": {
+                "axisBorderShow": false,
+                "axisCenteredZero": false,
+                "axisColorMode": "text",
+                "axisLabel": "",
+                "axisPlacement": "auto",
+                "barAlignment": 0,
+                "barWidthFactor": 0.6,
+                "drawStyle": "line",
+                "fillOpacity": 0,
+                "gradientMode": "none",
+                "hideFrom": {
+                  "legend": false,
+                  "tooltip": false,
+                  "viz": false
+                },
+                "insertNulls": false,
+                "lineInterpolation": "linear",
+                "lineWidth": 1,
+                "pointSize": 5,
+                "scaleDistribution": {
+                  "type": "linear"
+                },
+                "showPoints": "auto",
+                "spanNulls": false,
+                "stacking": {
+                  "group": "A",
+                  "mode": "none"
+                },
+                "thresholdsStyle": {
+                  "mode": "off"
+                }
+              },
+              "mappings": [],
+              "thresholds": {
+                "mode": "absolute",
+                "steps": [
+                  {
+                    "color": "green",
+                    "value": null
+                  },
+                  {
+                    "color": "red",
+                    "value": 80
+                  }
+                ]
+              }
+            },
+            "overrides": []
+          },
+          "gridPos": {
+            "h": 8,
+            "w": 12,
+            "x": 0,
+            "y": 70
+          },
+          "id": 238,
+          "options": {
+            "legend": {
+              "calcs": [],
+              "displayMode": "list",
+              "placement": "bottom",
+              "showLegend": true
+            },
+            "tooltip": {
+              "mode": "single",
+              "sort": "none"
+            }
+          },
+          "targets": [
+            {
+              "datasource": {
+                "type": "prometheus",
+                "uid": "${DS_PROMETHEUS}"
+              },
+              "editorMode": "builder",
+              "expr": 
"metrics_UnreleasedPartitionLocationCount_Value{role=\"Worker\", 
instance=~\"${instance}\"}",
+              "instant": false,
+              "range": true,
+              "refId": "A"
+            }
+          ],
+          "title": "metrics_UnreleasedPartitionLocationCount_Value",
+          "type": "timeseries"
         }
       ],
-      "title": "metrics_PartitionFileSizeBytes_Max",
-      "type": "timeseries"
+      "title": "Worker",
+      "type": "row"
     },
     {
       "collapsed": true,
diff --git 
a/worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
 
b/worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
index 932890237..e0f16c01a 100644
--- 
a/worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
+++ 
b/worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
@@ -32,9 +32,11 @@ import org.slf4j.LoggerFactory;
 
 import org.apache.celeborn.common.CelebornConf;
 import org.apache.celeborn.common.meta.*;
+import org.apache.celeborn.common.metrics.source.AbstractSource;
 import org.apache.celeborn.common.protocol.PartitionSplitMode;
 import org.apache.celeborn.common.protocol.PartitionType;
 import org.apache.celeborn.common.protocol.StorageInfo;
+import org.apache.celeborn.service.deploy.worker.WorkerSource;
 import 
org.apache.celeborn.service.deploy.worker.congestcontrol.CongestionController;
 import 
org.apache.celeborn.service.deploy.worker.congestcontrol.UserCongestionControlContext;
 import org.apache.celeborn.service.deploy.worker.memory.MemoryManager;
@@ -51,6 +53,7 @@ public class PartitionDataWriter implements DeviceObserver {
   private final long memoryFileStorageMaxFileSize;
   private final AtomicInteger numPendingWrites = new AtomicInteger(0);
   private final PartitionDataWriterContext writerContext;
+  protected final AbstractSource source; // metrics
   private final PartitionType partitionType;
   private final String writerString;
   private final StorageManager storageManager;
@@ -61,12 +64,14 @@ public class PartitionDataWriter implements DeviceObserver {
 
   public PartitionDataWriter(
       StorageManager storageManager,
+      AbstractSource workerSource,
       CelebornConf conf,
       DeviceMonitor deviceMonitor,
       PartitionDataWriterContext writerContext,
       PartitionType partitionType) {
     memoryFileStorageMaxFileSize = conf.workerMemoryFileStorageMaxFileSize();
     this.writerContext = writerContext;
+    this.source = workerSource;
 
     this.storageManager = storageManager;
     this.splitThreshold = writerContext.getSplitThreshold();
@@ -204,7 +209,9 @@ public class PartitionDataWriter implements DeviceObserver {
   }
 
   public synchronized long close() {
-    return currentTierWriter.close();
+    long length = currentTierWriter.close();
+    source.updateHistogram(WorkerSource.PARTITION_FILE_SIZE(), length);
+    return length;
   }
 
   public FileInfo getCurrentFileInfo() {
diff --git 
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
 
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
index f6db53807..3070e4b94 100644
--- 
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
+++ 
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
@@ -468,6 +468,7 @@ final private[worker] class StorageManager(conf: 
CelebornConf, workerSource: Abs
       try {
         new PartitionDataWriter(
           this,
+          workerSource,
           conf,
           deviceMonitor,
           partitionDataWriterContext,
diff --git 
a/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/local/DiskMapPartitionDataWriterSuiteJ.java
 
b/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/local/DiskMapPartitionDataWriterSuiteJ.java
index 97936d926..17392f464 100644
--- 
a/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/local/DiskMapPartitionDataWriterSuiteJ.java
+++ 
b/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/local/DiskMapPartitionDataWriterSuiteJ.java
@@ -137,6 +137,7 @@ public class DiskMapPartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, false, CONF, 
storagePolicy, context),
+            source,
             CONF,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context,
@@ -162,6 +163,12 @@ public class DiskMapPartitionDataWriterSuiteJ {
 
     assertEquals(length.get(), bytesWritten);
     assertEquals(new File(fileWriter.getFilePath()).length(), bytesWritten);
+    assert 
scala.collection.JavaConverters.asJavaCollectionConverter(source.histograms().toSeq())
+        .asJavaCollection().stream()
+        .anyMatch(
+            histogram ->
+                histogram.name().equals(WorkerSource.PARTITION_FILE_SIZE())
+                    && histogram.histogram().getSnapshot().getMax() > 0);
   }
 
   private byte[] generateData(int partitionId) {
diff --git 
a/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/local/DiskReducePartitionDataWriterSuiteJ.java
 
b/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/local/DiskReducePartitionDataWriterSuiteJ.java
index 297df70c7..6fbbda71a 100644
--- 
a/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/local/DiskReducePartitionDataWriterSuiteJ.java
+++ 
b/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/local/DiskReducePartitionDataWriterSuiteJ.java
@@ -284,6 +284,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, CONF, 
storagePolicy, context),
+            source,
             CONF,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context,
@@ -338,6 +339,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, CONF, 
storagePolicy, context),
+            source,
             CONF,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context,
@@ -393,6 +395,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, CONF, 
storagePolicy, context),
+            source,
             CONF,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context,
@@ -462,6 +465,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, CONF, 
storagePolicy, context),
+            source,
             CONF,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context,
@@ -581,6 +585,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, conf, 
storagePolicy, context1),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context1,
@@ -613,6 +618,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, conf, 
storagePolicy, context2),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context2,
@@ -645,6 +651,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, conf, 
storagePolicy, context3),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context3,
@@ -676,6 +683,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, conf, 
storagePolicy, context4),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context4,
@@ -709,6 +717,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, conf, 
storagePolicy, context5),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context5,
@@ -741,6 +750,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, conf, 
storagePolicy, context6),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context6,
@@ -775,6 +785,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, conf, 
storagePolicy, context7),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context7,
@@ -808,6 +819,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, conf, 
storagePolicy, context8),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context8,
@@ -842,6 +854,7 @@ public class DiskReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareDiskFileTestEnvironment(
                 tempDir, userIdentifier, localFlusher, true, conf, 
storagePolicy, context9),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context9,
diff --git 
a/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/memory/MemoryReducePartitionDataWriterSuiteJ.java
 
b/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/memory/MemoryReducePartitionDataWriterSuiteJ.java
index 8da338bf3..006035d85 100644
--- 
a/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/memory/MemoryReducePartitionDataWriterSuiteJ.java
+++ 
b/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/memory/MemoryReducePartitionDataWriterSuiteJ.java
@@ -302,6 +302,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareMemoryFileTestEnvironment(
                 userIdentifier, true, storageManager, storagePolicy, CONF, 
source, writerContext),
+            source,
             CONF,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             writerContext,
@@ -356,6 +357,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareMemoryFileTestEnvironment(
                 userIdentifier, true, storageManager, storagePolicy, CONF, 
source, writerContext),
+            source,
             CONF,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             writerContext,
@@ -419,6 +421,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
                 flushNotifier,
                 context1,
                 storagePolicy),
+            source,
             CONF,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context1,
@@ -480,6 +483,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
                 flushNotifier,
                 context,
                 storagePolicy),
+            source,
             CONF,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context,
@@ -568,6 +572,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
                 flushNotifier,
                 context,
                 storagePolicy),
+            source,
             CONF,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             context,
@@ -690,6 +695,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareMemoryFileTestEnvironment(
                 userIdentifier, true, storageManager, storagePolicy, conf, 
source, writerContext1),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             writerContext1,
@@ -722,6 +728,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareMemoryFileTestEnvironment(
                 userIdentifier, true, storageManager, storagePolicy, conf, 
source, writerContext2),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             writerContext2,
@@ -754,6 +761,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareMemoryFileTestEnvironment(
                 userIdentifier, true, storageManager, storagePolicy, conf, 
source, writerContext3),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             writerContext3,
@@ -785,6 +793,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareMemoryFileTestEnvironment(
                 userIdentifier, true, storageManager, storagePolicy, conf, 
source, writerContext4),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             writerContext4,
@@ -818,6 +827,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareMemoryFileTestEnvironment(
                 userIdentifier, true, storageManager, storagePolicy, conf, 
source, writerContext5),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             writerContext5,
@@ -850,6 +860,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareMemoryFileTestEnvironment(
                 userIdentifier, true, storageManager, storagePolicy, conf, 
source, writerContext6),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             writerContext6,
@@ -884,6 +895,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareMemoryFileTestEnvironment(
                 userIdentifier, true, storageManager, storagePolicy, conf, 
source, writerContext7),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             writerContext7,
@@ -917,6 +929,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareMemoryFileTestEnvironment(
                 userIdentifier, true, storageManager, storagePolicy, conf, 
source, writerContext8),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             writerContext8,
@@ -951,6 +964,7 @@ public class MemoryReducePartitionDataWriterSuiteJ {
         new PartitionDataWriter(
             PartitionDataWriterSuiteUtils.prepareMemoryFileTestEnvironment(
                 userIdentifier, true, storageManager, storagePolicy, conf, 
source, writerContext9),
+            source,
             conf,
             DeviceMonitor$.MODULE$.EmptyMonitor(),
             writerContext9,

Reply via email to