This is an automated email from the ASF dual-hosted git repository.
nicholasjiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git
The following commit(s) were added to refs/heads/main by this push:
new 04231e07d [CELEBORN-2188] Abort multipart upload for S3 and OSS in
DfsTierWriter#handleException
04231e07d is described below
commit 04231e07dcaab6a75def6d28e3efe19d887beda3
Author: xxx <[email protected]>
AuthorDate: Mon Nov 3 20:40:37 2025 +0800
[CELEBORN-2188] Abort multipart upload for S3 and OSS in
DfsTierWriter#handleException
### What changes were proposed in this pull request?
Abort multipart upload for S3 and OSS in `DfsTierWriter#handleException`.
### Why are the changes needed?
When handling exception of S3 or OSS, `DfsTierWriter` should abort
multipart upload instead of complete.
### Does this PR resolve a correctness bug?
No.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI.
Closes #3522 from xy2953396112/CELEBORN-2188.
Authored-by: xxx <[email protected]>
Signed-off-by: SteNicholas <[email protected]>
---
.../apache/celeborn/service/deploy/worker/storage/TierWriter.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala
index 530b345bf..352abe1e6 100644
---
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala
+++
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala
@@ -736,12 +736,12 @@ class DfsTierWriter(
override def handleException(): Unit = {
if (s3MultipartUploadHandler != null) {
logWarning(s"Abort s3 multipart upload for ${fileInfo.getFilePath}")
- s3MultipartUploadHandler.complete()
+ s3MultipartUploadHandler.abort()
s3MultipartUploadHandler.close()
}
if (ossMultipartUploadHandler != null) {
logWarning(s"Abort Oss multipart upload for ${fileInfo.getFilePath}")
- ossMultipartUploadHandler.complete()
+ ossMultipartUploadHandler.abort()
ossMultipartUploadHandler.close()
}
}