This is an automated email from the ASF dual-hosted git repository.
nicholasjiang pushed a commit to branch branch-0.6
in repository https://gitbox.apache.org/repos/asf/celeborn.git
The following commit(s) were added to refs/heads/branch-0.6 by this push:
new f76930f1d [CELEBORN-2256] Helm chart: add support for setting
annotations on the service account (to support eks.amazonaws.com/role-arn)
f76930f1d is described below
commit f76930f1d2a2cdb9db34b8dadc68060562c1c99f
Author: Enrico Olivelli <[email protected]>
AuthorDate: Thu Feb 5 14:12:04 2026 +0800
[CELEBORN-2256] Helm chart: add support for setting annotations on the
service account (to support eks.amazonaws.com/role-arn)
### What changes were proposed in this pull request?
Adding support for setting "annotations" on the Celeborn Service Account.
Patch originally contributed by Filip Darmanovic Dzeri96
### Why are the changes needed?
This is needed to support AWS IAM roles in k8s EKS
### Does this PR resolve a correctness bug?
No
### Does this PR introduce _any_ user-facing change?
Yes, you can now configure the annotations.
### How was this patch tested?
Manual testing + unit tests
Closes #3595 from eolivelli/CELEBORN-2256.
Authored-by: Enrico Olivelli <[email protected]>
Signed-off-by: SteNicholas <[email protected]>
(cherry picked from commit 81d89f3ecac24fe22b29a2965a740c8bf93ce186)
Signed-off-by: SteNicholas <[email protected]>
---
charts/celeborn/templates/serviceaccount.yaml | 4 ++++
charts/celeborn/tests/serviceaccount_test.yaml | 14 ++++++++++++++
charts/celeborn/values.yaml | 2 ++
3 files changed, 20 insertions(+)
diff --git a/charts/celeborn/templates/serviceaccount.yaml
b/charts/celeborn/templates/serviceaccount.yaml
index 482ef0c18..174bd24a5 100644
--- a/charts/celeborn/templates/serviceaccount.yaml
+++ b/charts/celeborn/templates/serviceaccount.yaml
@@ -23,5 +23,9 @@ metadata:
namespace: {{ .Release.Namespace }}
labels:
{{- include "celeborn.labels" . | nindent 4 }}
+ annotations:
+ {{- with .Values.serviceAccount.annotations }}
+ {{- toYaml . | nindent 4 }}
+ {{- end }}
{{- end }}
diff --git a/charts/celeborn/tests/serviceaccount_test.yaml
b/charts/celeborn/tests/serviceaccount_test.yaml
index 1f92f48c4..caefd4273 100644
--- a/charts/celeborn/tests/serviceaccount_test.yaml
+++ b/charts/celeborn/tests/serviceaccount_test.yaml
@@ -55,3 +55,17 @@ tests:
kind: ServiceAccount
name: test-service-account
namespace: celeborn
+
+ - it: Should create service account with the specified annotations
+ set:
+ serviceAccount:
+ create: true
+ name: test-service-account
+ annotations:
+ eks.amazonaws.com/role-arn: arn:aws:iam::000000:role/Foo
+ asserts:
+ - equal:
+ path: metadata.annotations
+ value:
+ eks.amazonaws.com/role-arn: arn:aws:iam::000000:role/Foo
+ template: serviceaccount.yaml
\ No newline at end of file
diff --git a/charts/celeborn/values.yaml b/charts/celeborn/values.yaml
index 963742a6c..4265101e4 100644
--- a/charts/celeborn/values.yaml
+++ b/charts/celeborn/values.yaml
@@ -405,6 +405,8 @@ serviceAccount:
create: false
# -- (Optional) Name of the Celeborn service account.
name: ""
+ # -- (Optional) Additional annotations, example: eks.amazonaws.com/role-arn:
arn:aws:iam::0000000000:role/XXXXXXX
+ annotations: {}
rbac:
create: true
