This is an automated email from the ASF dual-hosted git repository.
SteNicholas pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git
The following commit(s) were added to refs/heads/main by this push:
new fc0875674 [CELEBORN-2320] Grafana dashboard linter should build from a
checkout instead
fc0875674 is described below
commit fc087567442427cb1b3b161d65a7d3eb7080c345
Author: SteNicholas <[email protected]>
AuthorDate: Fri May 8 15:41:12 2026 +0800
[CELEBORN-2320] Grafana dashboard linter should build from a checkout
instead
### What changes were proposed in this pull request?
Grafana dashboard linter should build from a checkout instead.
Backport https://github.com/grafana/dashboard-linter/pull/252.
### Why are the changes needed?
This PR introduces
[GoReleaser](https://github.com/goreleaser/goreleaser-action) to help create
GitHub releases and compiled binaries.
The new release workflow will trigger on git tags starting with v.
In particular, providing pre-built release binaries addresses the following
problem currently seen in main:
```
go: downloading github.com/grafana/dashboard-linter v0.1.0
go: github.com/grafana/dashboard-linterlatest (in
github.com/grafana/dashboard-linterv0.1.0):
The go.mod file for the module providing named packages contains
one or
more replace directives. It must not contain directives that would
cause
it to be interpreted differently than if it were the main module.
```
`go install github.com/grafana/dashboard-linter<version>` does not
currently work because `go.mod` contains a `replace` directive — Go refuses to
install a module with replaces. Build from a checkout instead:
```
$ git clone https://github.com/grafana/dashboard-linter.git
$ cd dashboard-linter
$ go build -o dashboard-linter .
$ ./dashboard-linter lint dashboard.json
```
### Does this PR resolve a correctness bug?
No.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
`Grafana Dashboard CI / lint (pull_request)`.
Closes #3679 from SteNicholas/CELEBORN-2320.
Authored-by: SteNicholas <[email protected]>
Signed-off-by: SteNicholas <[email protected]>
---
.github/workflows/grafana.yml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/grafana.yml b/.github/workflows/grafana.yml
index 2632e213e..ea8cf60ce 100644
--- a/.github/workflows/grafana.yml
+++ b/.github/workflows/grafana.yml
@@ -44,10 +44,13 @@ jobs:
check-latest: true
# See https://github.com/grafana/dashboard-linter
- name: Install dashboard-linter
- run: go install github.com/grafana/dashboard-linter@latest
+ run: |
+ git clone https://github.com/grafana/dashboard-linter.git
+ cd dashboard-linter
+ go build -o dashboard-linter
- name: Lint Celeborn Dashboards
run: |
for dashboard in assets/grafana/*.json; do
python3 dev/lint_grafana.py "$dashboard"
- dashboard-linter lint "$dashboard" --config assets/grafana/.lint
--strict
+ ./dashboard-linter/dashboard-linter lint "$dashboard" --config
assets/grafana/.lint --strict
done
