[
https://issues.apache.org/jira/browse/CELIX-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Menno van der Graaf updated CELIX-290:
--------------------------------------
Description:
Bugs:
-unit tests failing, exhibiting undefined behavior. the framework mocks are
incorrectly implemented, and as a result, the reliant tests fail.
-Cmake warning in framework "framework/Cmakelist.txt"
-sub-par coverage of framework "resolver.c"
-build warnings in the framework unit tests.
Please find attached the patch that implements the following:
Changes/fixes:
-fixed cmake warning in framework/CMakelist.txt (removed brackets from
[COPYONLY] at line 351/353)
-fixed build warning in framework bundle_cache_test.cpp (mktemp depricated,
used mkstemp instead)
-fixed a dev note accidentaly left in framework service_registry_test.cpp (used
preprocessor symbol as dev note, will not do again)
-fixed a lot of the framework mocks, used to not assign any of the output
parameters, resulting in undefined behaviour
-updated most framework tests to accommodate for the mock changes
-expanded framework resolver test (WIP)
now how does this patch stuff work..
was:
Bugs:
-unit tests failing, exhibiting undefined behavior. the framework mocks are
incorrectly implemented, and as a result, the reliant tests fail.
-Cmake warning in framework "framework/Cmakelist.txt"
-sub-par coverage of framework "resolver.c"
-build warnings in the framework unit tests.
Changes/fixes:
-fixed cmake warning in framework/CMakelist.txt (removed brackets from
[COPYONLY] at line 351/353)
-fixed build warning in framework bundle_cache_test.cpp (mktemp depricated,
used mkstemp instead)
-fixed a dev note accidentaly left in framework service_registry_test.cpp (used
preprocessor symbol as dev note, will not do again)
-fixed a lot of the framework mocks, used to not assign any of the output
parameters, resulting in undefined behaviour
-updated most framework tests to accommodate for the mock changes
-expanded framework resolver test (WIP)
now how does this patch stuff work..
> Mock fixes, CMakelist fix, build warning fix
> --------------------------------------------
>
> Key: CELIX-290
> URL: https://issues.apache.org/jira/browse/CELIX-290
> Project: Celix
> Issue Type: Bug
> Components: Framework
> Reporter: Menno van der Graaf
> Labels: newbie, patch, test
>
> Bugs:
> -unit tests failing, exhibiting undefined behavior. the framework mocks are
> incorrectly implemented, and as a result, the reliant tests fail.
> -Cmake warning in framework "framework/Cmakelist.txt"
> -sub-par coverage of framework "resolver.c"
> -build warnings in the framework unit tests.
> Please find attached the patch that implements the following:
> Changes/fixes:
> -fixed cmake warning in framework/CMakelist.txt (removed brackets from
> [COPYONLY] at line 351/353)
> -fixed build warning in framework bundle_cache_test.cpp (mktemp depricated,
> used mkstemp instead)
> -fixed a dev note accidentaly left in framework service_registry_test.cpp
> (used preprocessor symbol as dev note, will not do again)
> -fixed a lot of the framework mocks, used to not assign any of the output
> parameters, resulting in undefined behaviour
> -updated most framework tests to accommodate for the mock changes
> -expanded framework resolver test (WIP)
> now how does this patch stuff work..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
