This is an automated email from the ASF dual-hosted git repository.
pengzheng pushed a commit to branch feature/refactor_bundle_cache
in repository https://gitbox.apache.org/repos/asf/celix.git
The following commit(s) were added to refs/heads/feature/refactor_bundle_cache
by this push:
new 5e8ed191 Minor improvement of bundleCommand_execute.
5e8ed191 is described below
commit 5e8ed19124a3ebb3f1bf9fa49099329678447862
Author: PengZheng <[email protected]>
AuthorDate: Fri Mar 17 12:27:19 2023 +0800
Minor improvement of bundleCommand_execute.
---
bundles/shell/shell/src/bundle_command.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/bundles/shell/shell/src/bundle_command.c
b/bundles/shell/shell/src/bundle_command.c
index 94970be9..deb8655a 100644
--- a/bundles/shell/shell/src/bundle_command.c
+++ b/bundles/shell/shell/src/bundle_command.c
@@ -57,19 +57,16 @@ bool bundleCommand_execute(void *handle, const char
*constCommandLine, FILE *out
}
free(command);
- bool succeeded = false;
if (!validArgs) {
- succeeded = false;
goto cleanup;
}
for (int i = 0; i < celix_arrayList_size(bundleIds); i++) {
long bndId = celix_arrayList_getLong(bundleIds, i);
celix_framework_t* fw = celix_bundleContext_getFramework(ctx);
ctrl(fw, bndId);
- succeeded = true;
}
cleanup:
celix_arrayList_destroy(bundleIds);
- return succeeded;
+ return validArgs;
}