This is an automated email from the ASF dual-hosted git repository.
pnoltes pushed a commit to branch feature/599-rust-hello-world-bundle
in repository https://gitbox.apache.org/repos/asf/celix.git
The following commit(s) were added to
refs/heads/feature/599-rust-hello-world-bundle by this push:
new a0c2ca32 599: Update the experimental Rust readme
a0c2ca32 is described below
commit a0c2ca322280910e6b77ffb7b55cfe48157a02ad
Author: Pepijn Noltes <[email protected]>
AuthorDate: Mon Jul 31 23:16:08 2023 +0200
599: Update the experimental Rust readme
---
misc/experimental/rust/.gitignore | 2 +-
misc/experimental/rust/Cargo.toml | 1 -
misc/experimental/rust/README.md | 3 ++-
misc/experimental/rust/hello_world_activator/src/lib.rs | 5 -----
4 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/misc/experimental/rust/.gitignore
b/misc/experimental/rust/.gitignore
index 71debfb5..8abe0fcc 100644
--- a/misc/experimental/rust/.gitignore
+++ b/misc/experimental/rust/.gitignore
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
-Cargo.lock
\ No newline at end of file
+Cargo.lock
diff --git a/misc/experimental/rust/Cargo.toml
b/misc/experimental/rust/Cargo.toml
index 6e21189d..f0ed38b9 100644
--- a/misc/experimental/rust/Cargo.toml
+++ b/misc/experimental/rust/Cargo.toml
@@ -15,7 +15,6 @@
# specific language governing permissions and limitations
# under the License.
-
[workspace]
members = [
"hello_world_activator",
diff --git a/misc/experimental/rust/README.md b/misc/experimental/rust/README.md
index 28096e8e..552781e9 100644
--- a/misc/experimental/rust/README.md
+++ b/misc/experimental/rust/README.md
@@ -24,4 +24,5 @@ limitations under the License.
This experimental bundles shows that it is possible to write a bundle in Rust,
it directly uses the Apache Celix C api
and is not intended to be used in production.
-Ideally Rust support in Apache Celix is done by first adding a Rust api and
use that for Rust bundles.
+Ideally Rust support is done by adding a Rust API for Apache Celix and use
that API for Rust bundles, the current
+implementation only shows that is possible to write a bundle in Rust that gets
called by Apache Celix framework.
diff --git a/misc/experimental/rust/hello_world_activator/src/lib.rs
b/misc/experimental/rust/hello_world_activator/src/lib.rs
index eb78bbd2..19e6d05a 100644
--- a/misc/experimental/rust/hello_world_activator/src/lib.rs
+++ b/misc/experimental/rust/hello_world_activator/src/lib.rs
@@ -19,11 +19,6 @@
use std::os::raw::c_void;
-// TODO use celix_bundleActivator_create to create a bundle activator
-// pub struct RustBundleActivator {
-// bundle_context: *mut c_void, /*TODO use bindgen to generate the correct
ctx type*/
-// }
-
#[no_mangle]
pub unsafe extern "C" fn celix_bundleActivator_start(_data: *mut c_void,
_context: *mut c_void) -> i32 {
println!("Rust Bundle started!");
