This is an automated email from the ASF dual-hosted git repository. rlenferink pushed a commit to branch feature/add-build-job-for-dev-container in repository https://gitbox.apache.org/repos/asf/celix.git
commit 2fa08300b069577fb141ca83b7341a2ebfbdcb3d Author: Roy Lenferink <[email protected]> AuthorDate: Sun Jan 7 13:25:54 2024 +0100 container: Rename 'start' script to 'run' script This matches more with the concept of passing custom commands, where a container can be started and exited --- container/README.md | 7 +++---- container/build-ubuntu-container.sh | 1 - container/{start-ubuntu-container.sh => run-ubuntu-container.sh} | 0 container/support-scripts/build-all.sh | 1 - 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/container/README.md b/container/README.md index b958466a..4178c7ea 100644 --- a/container/README.md +++ b/container/README.md @@ -21,7 +21,7 @@ To always be able to develop on Celix with an up-to-date image, built the image cd <project-root> # Start a local container with the SSH daemon running -./container/start-ubuntu-container.sh +./container/run-ubuntu-container.sh ``` Now connect to the container via the remote container option of your favoured IDE and start building/developing. @@ -35,14 +35,14 @@ When finished with development and testing, press `CTRL + \` to stop the SSH dae ### Start locally with only a bash shell -The start script allows passing of additional paramters, which will override the starting of the SSH daemon. +The start script allows passing of additional parameters, which will override the starting of the SSH daemon. Execute the following commands to open a bash shell and build Celix from the command line: ```bash cd <project-root> # Start a local container and open a bash shell -./container/start-ubuntu-container.sh bash +./container/run-ubuntu-container.sh bash # Build Apache Celix mkdir celix-build @@ -53,4 +53,3 @@ make -j # Run the unit tests for Apache Celix ctest --output-on-failure ``` - diff --git a/container/build-ubuntu-container.sh b/container/build-ubuntu-container.sh index aafa8aa0..457a5639 100755 --- a/container/build-ubuntu-container.sh +++ b/container/build-ubuntu-container.sh @@ -32,4 +32,3 @@ fi cd "${SCRIPT_LOCATION}" ${CONTAINER_ENGINE} build -t apache/celix-dev:ubuntu-latest -f Containerfile.ubuntu . - diff --git a/container/start-ubuntu-container.sh b/container/run-ubuntu-container.sh similarity index 100% rename from container/start-ubuntu-container.sh rename to container/run-ubuntu-container.sh diff --git a/container/support-scripts/build-all.sh b/container/support-scripts/build-all.sh index 16acf6df..2e7500b2 100755 --- a/container/support-scripts/build-all.sh +++ b/container/support-scripts/build-all.sh @@ -27,4 +27,3 @@ cmake -DCMAKE_BUILD_TYPE=${BUILD_TYPE} \ -DRSA_SHM=ON \ -DRSA_REMOTE_SERVICE_ADMIN_SHM_V2=ON \ .. -
