svn commit: r1625482 - in /chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl: atompub/ browser/ webservices/

[fmui]

Author: fmui
Date: Wed Sep 17 08:15:10 2014
New Revision: 1625482

URL: http://svn.apache.org/r1625482
Log:
Server: improved error logging

Modified:
    
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/CmisAtomPubServlet.java
    
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/CmisBrowserBindingServlet.java
    
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/webservices/AbstractService.java

Modified: 
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/CmisAtomPubServlet.java
URL: 
http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/CmisAtomPubServlet.java?rev=1625482&r1=1625481&r2=1625482&view=diff
==============================================================================
--- 
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/CmisAtomPubServlet.java
 (original)
+++ 
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/atompub/CmisAtomPubServlet.java
 Wed Sep 17 08:15:10 2014
@@ -297,6 +297,10 @@ public class CmisAtomPubServlet extends 
         } else if (ex instanceof CmisBaseException) {
             statusCode = getErrorCode((CmisBaseException) ex);
             exceptionName = ((CmisBaseException) ex).getExceptionName();
+
+            if (statusCode == HttpServletResponse.SC_INTERNAL_SERVER_ERROR) {
+                LOG.error(ex.getMessage(), ex);
+            }
         } else if (ex instanceof IOException) {
             LOG.warn(ex.getMessage(), ex);
         } else {

Modified: 
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/CmisBrowserBindingServlet.java
URL: 
http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/CmisBrowserBindingServlet.java?rev=1625482&r1=1625481&r2=1625482&view=diff
==============================================================================
--- 
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/CmisBrowserBindingServlet.java
 (original)
+++ 
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/browser/CmisBrowserBindingServlet.java
 Wed Sep 17 08:15:10 2014
@@ -444,6 +444,10 @@ public class CmisBrowserBindingServlet e
             } else if (ex instanceof CmisBaseException) {
                 statusCode = getErrorCode((CmisBaseException) ex);
                 exceptionName = ((CmisBaseException) ex).getExceptionName();
+
+                if (statusCode == 
HttpServletResponse.SC_INTERNAL_SERVER_ERROR) {
+                    LOG.error(ex.getMessage(), ex);
+                }
             } else if (ex instanceof IOException) {
                 LOG.warn(ex.getMessage(), ex);
             } else {

Modified: 
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/webservices/AbstractService.java
URL: 
http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/webservices/AbstractService.java?rev=1625482&r1=1625481&r2=1625482&view=diff
==============================================================================
--- 
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/webservices/AbstractService.java
 (original)
+++ 
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-bindings/src/main/java/org/apache/chemistry/opencmis/server/impl/webservices/AbstractService.java
 Wed Sep 17 08:15:10 2014
@@ -222,6 +222,7 @@ public abstract class AbstractService {
                 } else if (ex instanceof CmisPermissionDeniedException) {
                     fault.setType(EnumServiceException.PERMISSION_DENIED);
                 } else if (ex instanceof CmisStorageException) {
+                    LOG.error(ex.getMessage(), ex);
                     fault.setType(EnumServiceException.STORAGE);
                 } else if (ex instanceof CmisStreamNotSupportedException) {
                     fault.setType(EnumServiceException.STREAM_NOT_SUPPORTED);
@@ -229,6 +230,8 @@ public abstract class AbstractService {
                     fault.setType(EnumServiceException.UPDATE_CONFLICT);
                 } else if (ex instanceof CmisVersioningException) {
                     fault.setType(EnumServiceException.VERSIONING);
+                } else {
+                    LOG.error(ex.getMessage(), ex);
                 }
             } else {
                 fault.setMessage("An error occurred!");