Author: jpotts
Date: Sun Aug 27 16:53:02 2017
New Revision: 1806377
URL: http://svn.apache.org/viewvc?rev=1806377&view=rev
Log:
Small changes for PEP8 and pylint
Modified:
chemistry/cmislib/trunk/src/cmislib/atompub/binding.py
chemistry/cmislib/trunk/src/cmislib/browser/binding.py
chemistry/cmislib/trunk/src/cmislib/domain.py
chemistry/cmislib/trunk/src/cmislib/exceptions.py
Modified: chemistry/cmislib/trunk/src/cmislib/atompub/binding.py
URL:
http://svn.apache.org/viewvc/chemistry/cmislib/trunk/src/cmislib/atompub/binding.py?rev=1806377&r1=1806376&r2=1806377&view=diff
==============================================================================
--- chemistry/cmislib/trunk/src/cmislib/atompub/binding.py (original)
+++ chemistry/cmislib/trunk/src/cmislib/atompub/binding.py Sun Aug 27 16:53:02
2017
@@ -581,8 +581,8 @@ class AtomPubCmisObject(CmisObject):
for valNode in valNodeList:
try:
propertyValue.append(parsePropValue(valNode.
-
childNodes[0].data,
-
node.localName))
+ childNodes[0].data,
+ node.localName))
except IndexError:
pass
else:
@@ -3476,7 +3476,7 @@ class AtomPubACL(ACL):
"""
ace = AtomPubACE(principalId, access, direct)
if not self._entries:
- self._entries = {ace.principalId : ace}
+ self._entries = {ace.principalId: ace}
else:
if self._entries.has_key(principalId):
if access not in self._entries[principalId].permissions:
@@ -3484,7 +3484,7 @@ class AtomPubACL(ACL):
perms.append(access)
self.removeEntry(principalId)
if not self._entries:
- self._entries = {principalId : AtomPubACE(principalId,
perms, direct)}
+ self._entries = {principalId: AtomPubACE(principalId,
perms, direct)}
else:
self._entries[principalId] = AtomPubACE(principalId,
perms, direct)
else:
Modified: chemistry/cmislib/trunk/src/cmislib/browser/binding.py
URL:
http://svn.apache.org/viewvc/chemistry/cmislib/trunk/src/cmislib/browser/binding.py?rev=1806377&r1=1806376&r2=1806377&view=diff
==============================================================================
--- chemistry/cmislib/trunk/src/cmislib/browser/binding.py (original)
+++ chemistry/cmislib/trunk/src/cmislib/browser/binding.py Sun Aug 27 16:53:02
2017
@@ -28,11 +28,11 @@ from cmislib.exceptions import CmisExcep
from cmislib.net import RESTService as Rest
from cmislib.util import parsePropValueByType, parseDateTimeValue, safe_quote,\
safe_urlencode
+from cmislib import messages
import json
import logging
import StringIO
import time
-from urllib import urlencode, quote
CMIS_FORM_TYPE = 'application/x-www-form-urlencoded;charset=utf-8'
@@ -117,6 +117,11 @@ class RepositoryService(RepositoryServic
"""
def getRepository(self, client, repositoryId):
+
+ """
+ Gets the repository for the specified repository ID.
+ """
+
result = client.binding.get(client.repositoryUrl, client.username,
client.password, **client.extArgs)
if repositoryId in result:
@@ -125,6 +130,11 @@ class RepositoryService(RepositoryServic
raise ObjectNotFoundException(url=client.repositoryUrl)
def getRepositories(self, client):
+
+ """
+ Gets all of the repositories for this client.
+ """
+
result = client.binding.get(client.repositoryUrl, client.username,
client.password, **client.extArgs)
repositories = []
@@ -569,7 +579,7 @@ class BrowserCmisObject(object):
for i, entry in enumerate(acl.getAddedAces()):
fields['addACEPrincipal[%d]' % i] = entry.principalId
for j, perm in enumerate(entry.permissions):
- fields['addACEPermission[%d][%d]'% (i, j)] = perm
+ fields['addACEPermission[%d][%d]' % (i, j)] = perm
for i, entry in enumerate(acl.getRemovedAces()):
fields['removeACEPrincipal[%d]' % i] = entry.principalId
for j, perm in enumerate(entry.permissions):
@@ -2859,6 +2869,11 @@ class BrowserACL(ACL):
entries = property(getEntries)
def getOriginalEntries(self):
+
+ """
+ Returns the original entries.
+ """
+
return self._originalEntries
originalEntries = property(getOriginalEntries)
@@ -3033,7 +3048,7 @@ class BrowserChangeEntry(ChangeEntry):
"""
if not self._properties:
props = self._data.get('properties')
- for prop in self._data.get('properties').itervalues():
+ for prop in props.itervalues():
# property could be multi-valued
if type(prop['value']) is list:
propVal = []
@@ -3102,6 +3117,7 @@ class BrowserChangeEntryResultSet(Browse
return self._results
+
class BrowserRendition(object):
"""
@@ -3412,6 +3428,7 @@ class ACLSerializer(object):
return json.dumps(aces)
+
class ChangeEntrySerializer(object):
"""
Modified: chemistry/cmislib/trunk/src/cmislib/domain.py
URL:
http://svn.apache.org/viewvc/chemistry/cmislib/trunk/src/cmislib/domain.py?rev=1806377&r1=1806376&r2=1806377&view=diff
==============================================================================
--- chemistry/cmislib/trunk/src/cmislib/domain.py (original)
+++ chemistry/cmislib/trunk/src/cmislib/domain.py Sun Aug 27 16:53:02 2017
@@ -1075,6 +1075,7 @@ class ResultSet(object):
Returns the prev page of results as a dictionary of
:class:`CmisObject` objects or its appropriate sub-type. This only
works when the server returns a "prev" link. Not all of them do.
+
>>> resultSet.hasPrev()
True
>>> results = resultSet.getPrev()
@@ -1091,6 +1092,7 @@ class ResultSet(object):
"""
Returns the next page of results as a dictionary of
:class:`CmisObject` objects or its appropriate sub-type.
+
>>> resultSet.hasNext()
True
>>> results = resultSet.getNext()
@@ -2028,9 +2030,8 @@ class ACE(object):
if (
isinstance(other, self.__class__) and
self.principalId == other.principalId and
- self.direct == other.direct and
- not(set(self.permissions) ^ set(other.permissions))
- ):
+ self.direct == other.direct and
+ not(set(self.permissions) ^ set(other.permissions))):
return 0
return -1
Modified: chemistry/cmislib/trunk/src/cmislib/exceptions.py
URL:
http://svn.apache.org/viewvc/chemistry/cmislib/trunk/src/cmislib/exceptions.py?rev=1806377&r1=1806376&r2=1806377&view=diff
==============================================================================
--- chemistry/cmislib/trunk/src/cmislib/exceptions.py (original)
+++ chemistry/cmislib/trunk/src/cmislib/exceptions.py Sun Aug 27 16:53:02 2017
@@ -21,6 +21,8 @@
"""
This module contains exceptions used throughout the API.
"""
+
+
class CmisException(Exception):
"""
