CLIMATE-607 - Fix breaking config parser tests - A previous change split the various config parsing components out into separate modules. The config parser import name was changed in the test_config_parsing tests module but the actual call to the new import was not. - One of the logger mocks incorrectly referenced the old module name. This was causing the mocking library to not recognize that the correct logging function was in fact being called.
Project: http://git-wip-us.apache.org/repos/asf/climate/repo Commit: http://git-wip-us.apache.org/repos/asf/climate/commit/4c6d8366 Tree: http://git-wip-us.apache.org/repos/asf/climate/tree/4c6d8366 Diff: http://git-wip-us.apache.org/repos/asf/climate/diff/4c6d8366 Branch: refs/heads/master Commit: 4c6d8366577a9940d73667c4bd2d235aaefbd748 Parents: dca99e0 Author: Michael Joyce <[email protected]> Authored: Wed Mar 18 11:34:09 2015 -0700 Committer: Michael Joyce <[email protected]> Committed: Wed Mar 18 11:34:09 2015 -0700 ---------------------------------------------------------------------- ocw-config-runner/tests/test_config_parsing.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/climate/blob/4c6d8366/ocw-config-runner/tests/test_config_parsing.py ---------------------------------------------------------------------- diff --git a/ocw-config-runner/tests/test_config_parsing.py b/ocw-config-runner/tests/test_config_parsing.py index 36ef9be..01062e1 100644 --- a/ocw-config-runner/tests/test_config_parsing.py +++ b/ocw-config-runner/tests/test_config_parsing.py @@ -500,12 +500,12 @@ class TestRCMEDDatasetConfig(unittest.TestCase): self.invalid_rcmed = conf[1] def test_valid_rcmed_config(self): - ret = config_runner._valid_dataset_config_data(self.valid_rcmed) + ret = parser._valid_dataset_config_data(self.valid_rcmed) self.assertTrue(ret) - @patch('ocw_evaluation_from_config.logger') + @patch('configuration_parsing.logger') def test_invalid_rcmed_config(self, mock_logger): - config_runner._valid_dataset_config_data(self.invalid_rcmed) + parser._valid_dataset_config_data(self.invalid_rcmed) present_keys = set(self.invalid_rcmed.keys()) missing_keys = self.required_rcmed_keys - present_keys
