wenchaozhang-123 opened a new pull request, #716:
URL: https://github.com/apache/cloudberry/pull/716
We should have done it this way all along, but we accidentally got away with
using the wrong BIO field up until OpenSSL 3.2. There, the library's BIO
routines that we rely on use the "data" field for their own purposes, and our
conflicting use causes assorted weird behaviors up to and including core dumps
when SSL connections are attempted. Switch to using the approved field for the
purpose, i.e. app_data.
While at it, remove our configure probes for BIO_get_data as well as the
fallback implementation. BIO_{get,set}_app_data have been there since long
before any OpenSSL version that we still support, even in the back branches.
Also, update src/test/ssl/t/001_ssltests.pl to allow for a minor change in
an error message spelling that evidently came in with 3.2.
Tristan Partin and Bo Andreson. Back-patch to all supported branches.
Discussion:
https://postgr.es/m/can55fz1eddysyal7mv+osluij2h_u6hvd4qmv-7pk7jkji0...@mail.gmail.com
<!--Thank you for contributing!-->
<!--In case of an existing issue or discussions, please reference it-->
fix #ISSUE_Number
<!--Remove this section if no corresponding issue.-->
---
### Change logs
_Describe your change clearly, including what problem is being solved or
what feature is being added._
_If it has some breaking backward or forward compatibility, please clary._
### Why are the changes needed?
_Describe why the changes are necessary._
### Does this PR introduce any user-facing change?
_If yes, please clarify the previous behavior and the change this PR
proposes._
### How was this patch tested?
_Please detail how the changes were tested, including manual tests and any
relevant unit or integration tests._
### Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull
request, please check them:
- [ ] Make sure your Pull Request has a clear title and commit message. You
can take
[git-commit](https://github.com/cloudberrydb/cloudberrydb/blob/main/.gitmessage)
template as a reference.
- [ ] Sign the Contributor License Agreement as prompted for your first-time
contribution(*One-time setup*).
- [ ] Learn the [coding contribution
guide](https://cloudberrydb.org/contribute/code), including our code
conventions, workflow and more.
- [ ] List your communication in the [GitHub
Issues](https://github.com/cloudberrydb/cloudberrydb/issues) or
[Discussions](https://github.com/orgs/cloudberrydb/discussions) (if has or
needed).
- [ ] Document changes.
- [ ] Add tests for the change
- [ ] Pass `make installcheck`
- [ ] Pass `make -C src/test installcheck-cbdb-parallel`
- [ ] Feel free to request `cloudberrydb/dev` team for review and approval
when your PR is ready🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
