yjhjstz commented on code in PR #724:
URL: https://github.com/apache/cloudberry/pull/724#discussion_r1853184388
##########
src/backend/executor/nodeSeqscan.c:
##########
@@ -365,3 +398,60 @@ ExecSeqScanInitializeWorker(SeqScanState *node,
}
node->ss.ss_currentScanDesc = scandesc;
}
+
+/*
+ * Returns true if the element may be in the bloom filter.
+ */
+static bool
+PassByBloomFilter(SeqScanState *node, TupleTableSlot *slot)
+{
+ ScanKey sk;
+ Datum val;
+ bool isnull;
+ ListCell *lc;
+ bloom_filter *blm_filter;
+
+ foreach (lc, node->filters)
+ {
+ sk = lfirst(lc);
+ if (sk->sk_flags != SK_BLOOM_FILTER)
+ continue;
+
+ val = slot_getattr(slot, sk->sk_attno, &isnull);
+ if (isnull)
Review Comment:
```c++
CREATE TABLE distinct_1(a int);
CREATE TABLE distinct_2(a int);
INSERT INTO distinct_1 VALUES(1),(2),(NULL);
INSERT INTO distinct_2 VALUES(1),(NULL);
SELECT * FROM distinct_1, distinct_2 WHERE distinct_1.a IS NOT DISTINCT FROM
distinct_2.a;
```
test got wrong result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
