gfphoenix78 commented on code in PR #683:
URL: https://github.com/apache/cloudberry/pull/683#discussion_r1869520926
##########
src/backend/nodes/outfuncs.c:
##########
@@ -4045,6 +4045,25 @@ _outAlterDirectoryTableStmt(StringInfo str, const
AlterDirectoryTableStmt *node)
WRITE_BOOL_FIELD(unsettag);
}
+static void
+_outDropStmtInfo(StringInfo str, const DropStmt *node)
+{
+ WRITE_NODE_FIELD(objects);
+ WRITE_ENUM_FIELD(removeType, ObjectType);
+ WRITE_ENUM_FIELD(behavior, DropBehavior);
+ WRITE_BOOL_FIELD(missing_ok);
+ WRITE_BOOL_FIELD(concurrent);
+}
+
+static void
+_outDropDirectoryTableStmt(StringInfo str, const DropDirectoryTableStmt *node)
+{
+ WRITE_NODE_TYPE("DROPDIRECTORYTABLESTMT");
+
+ _outDropStmtInfo(str, (const DropStmt *) node);
+ WRITE_BOOL_FIELD(with_content);
+}
+
Review Comment:
These non-standard functions could be contained in `outfuncs_common.c`.
It has two benefits:
1. the `out` functions will have text and binary versions.
2. The additional code causes unneeded conflict in kernel upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
