jiaqizho commented on code in PR #731:
URL: https://github.com/apache/cloudberry/pull/731#discussion_r1870548330


##########
configure:
##########
@@ -2021,9 +2021,9 @@ $as_echo "$as_me: WARNING: $2: see the Autoconf 
documentation" >&2;}
 $as_echo "$as_me: WARNING: $2:     section \"Present But Cannot Be Compiled\"" 
>&2;}
     { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: $2: proceeding with the 
compiler's result" >&5
 $as_echo "$as_me: WARNING: $2: proceeding with the compiler's result" >&2;}
-( $as_echo "## ------------------------------------ ##

Review Comment:
   `configure` need generate by `configure.ac` in stand build env...
   
   why i have not saw the line changed in `configure.ac`?



##########
deploy/build/README.Linux.md:
##########
@@ -93,7 +93,7 @@ The following steps work on CentOS 7. For other CentOS 
versions, these steps mig
 
     ```shell
     # You need to enter your password to run.
-    sudo ~/cloudberrydb/deploy/build/README.Ubuntu.bash

Review Comment:
   Are the changes here necessary? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to