avamingli commented on code in PR #725:
URL: https://github.com/apache/cloudberry/pull/725#discussion_r1870717509
##########
src/backend/commands/taskcmds.c:
##########
@@ -109,6 +109,14 @@ DefineTask(ParseState *pstate, CreateTaskStmt *stmt)
}
}
+ if (!allowSystemTableMods && strncmp(stmt->taskname,
DYNAMIC_TASK_PREFIX, 25) == 0)
Review Comment:
This is a right align with tab of Postgres, however the original codes
ahead/behind have align problem.
You could find it in a IDE like VScode or vim.
The pg_task codes may need a pgindent at a right time.
##########
src/backend/commands/taskcmds.c:
##########
@@ -278,6 +286,13 @@ DropTask(ParseState *pstate, DropTaskStmt *stmt)
/* delete from pg_task_run_history according to the jobid */
if (OidIsValid(jobid))
{
+ if (!allowSystemTableMods && strncmp(stmt->taskname,
DYNAMIC_TASK_PREFIX, 25) == 0)
Review Comment:
Same with below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
