gongxun0928 commented on code in PR #763:
URL: https://github.com/apache/cloudberry/pull/763#discussion_r1879242995
##########
src/backend/access/rmgrdesc/smgrdesc.c:
##########
@@ -27,7 +27,7 @@ smgr_desc(StringInfo buf, XLogReaderState *record)
{
xl_smgr_create *xlrec = (xl_smgr_create *) rec;
char *path = relpathperm(xlrec->rnode, xlrec->forkNum);
- appendStringInfo(buf, "%s; smgr: %s", path, xlrec->impl ==
SMGR_MD ? "heap" : "ao");
+ appendStringInfo(buf, "%s; smgr: %s", path, xlrec->impl ==
SMGR_MD ? "heap" : (xlrec->impl == SMGR_AO ? "ao" : "unknown"));
Review Comment:
yeah. maybe i will add a function like
`extern const char* smgr_get_name(SMgrImpl impl);`
It can handle custom smgr normally in the cloudberrydb process, but in tools
such as pg_waldump, it can only be displayed as unknown
##########
src/backend/access/rmgrdesc/smgrdesc.c:
##########
@@ -27,7 +27,7 @@ smgr_desc(StringInfo buf, XLogReaderState *record)
{
xl_smgr_create *xlrec = (xl_smgr_create *) rec;
char *path = relpathperm(xlrec->rnode, xlrec->forkNum);
- appendStringInfo(buf, "%s; smgr: %s", path, xlrec->impl ==
SMGR_MD ? "heap" : "ao");
+ appendStringInfo(buf, "%s; smgr: %s", path, xlrec->impl ==
SMGR_MD ? "heap" : (xlrec->impl == SMGR_AO ? "ao" : "unknown"));
Review Comment:
yeah. i will add a function like
`extern const char* smgr_get_name(SMgrImpl impl);`
It can handle custom smgr normally in the cloudberrydb process, but in tools
such as pg_waldump, it can only be displayed as unknown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
