tuhaihe commented on PR #731: URL: https://github.com/apache/cloudberry/pull/731#issuecomment-2543003197
Finally got it done (nearly)! I reviewed all the changes file by file this week and found a few issues then fixed them. Now all the local tests (only one failed now) based on my latest changes have passed completely! As for that `latin1` encoding issue, we can add `PGCLIENTENCODING=UTF8` when running the test commands. ## Screenshots: * `PGCLIENTENCODING=UTF8 PGOPTIONS='-c optimizer=on' make -C src/test installcheck-cbdb-parallel` <img width="991" alt="image" src="https://github.com/user-attachments/assets/088e22fa-66ea-4bfd-b74a-80467956ec42"; /> * `PGCLIENTENCODING=UTF8 PGOPTIONS='-c optimizer=on' make installcheck` <img width="779" alt="image" src="https://github.com/user-attachments/assets/09620fe4-e4fb-4d0b-b0fc-01c6f9bbd865"; /> * `PGCLIENTENCODING=UTF8 PGOPTIONS='-c optimizer=off' make installcheck-world` <img width="1028" alt="image" src="https://github.com/user-attachments/assets/03de6ba1-8393-4287-b7a2-bc90920b3da2"; /> for the failed test, haven't changed the file `src/test/regress/expected/uaocs_compaction/stats.out`. I'm not sure about it. ## My tests My testing was based on the latest building Docker image: ``` docker run -it --rm -h cdw --shm-size=30gb apache/incubator-cloudberry:cbdb-build-rocky9-latest ``` Then pulling my branch: ``` git clone --branch cleanup-mails-and-names1126 https://github.com/tuhaihe/cloudberrydb.git ~/cloudberry ``` After that, compiled and installed the Cloudberry following this guide (https://github.com/edespino/cloudberry/blob/rocky9-dev-readme/deploy/build/README-rockylinux9.md). Lastly, ran the three tests mentioned above. FYI. ## Plan Except for the first two commits in this PR, most of the others are quite similar. I’m planning to squash them down into a single epic commit, and then we can start merging this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
