This is an automated email from the ASF dual-hosted git repository. maxyang pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit f9a2cd0bb8975c715bb5555c3d41d7fff38812b3 Author: Jimmy Yih <[email protected]> AuthorDate: Thu Mar 24 18:41:04 2022 -0700 Restore visibility of some GUCs to be viewable from pg_settings The checkpoint_timeout, archive_command, and data_directory GUC settings were hidden back in the early GPDB 4.0.X days to prevent users from messing with them. It should be fine to realign the visibility of these GUCs with how they are in Postgres (checkpoint_timeout and archive_command visible to all users and data_directory visible to superusers or users with pg_read_all_settings permission). They won't be documented in Greenplum GUC documentation so they'll still be somewhat hidden to individual users but not for us developers and the tools we build that may require checking their GUC values. This is mainly needed now to allow external tools such as pgbackrest to work properly. --- src/backend/utils/misc/guc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index a44d940622..1adc0ddf43 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -2872,7 +2872,7 @@ static struct config_int ConfigureNamesInt[] = {"checkpoint_timeout", PGC_SIGHUP, WAL_CHECKPOINTS, gettext_noop("Sets the maximum time between automatic WAL checkpoints."), NULL, - GUC_UNIT_S | GUC_NOT_IN_SAMPLE | GUC_NO_SHOW_ALL | GUC_DISALLOW_USER_SET + GUC_UNIT_S | GUC_NOT_IN_SAMPLE | GUC_DISALLOW_USER_SET }, &CheckPointTimeout, 300, 30, 86400, @@ -3927,7 +3927,7 @@ static struct config_string ConfigureNamesString[] = {"archive_command", PGC_SIGHUP, WAL_ARCHIVING, gettext_noop("Sets the shell command that will be called to archive a WAL file."), NULL, - GUC_NOT_IN_SAMPLE | GUC_NO_SHOW_ALL + GUC_NOT_IN_SAMPLE }, &XLogArchiveCommand, "", @@ -4441,7 +4441,7 @@ static struct config_string ConfigureNamesString[] = {"data_directory", PGC_POSTMASTER, FILE_LOCATIONS, gettext_noop("Sets the server's data directory."), NULL, - GUC_SUPERUSER_ONLY | GUC_DISALLOW_IN_AUTO_FILE | GUC_NO_SHOW_ALL | GUC_NOT_IN_SAMPLE + GUC_SUPERUSER_ONLY | GUC_DISALLOW_IN_AUTO_FILE | GUC_NOT_IN_SAMPLE }, &data_directory, NULL, --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
