jiaqizho commented on code in PR #813:
URL: https://github.com/apache/cloudberry/pull/813#discussion_r1897163196
##########
src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp:
##########
@@ -1554,6 +1554,7 @@ CTranslatorDXLToPlStmt::TranslateDXLTvf(
List *target_list = TranslateDXLProjList(
project_list_dxlnode, &base_table_context, nullptr,
output_context);
+ target_list = gpdb::ProcessRecordFuncTargetList(((FuncExpr *)
rtfunc->funcexpr)->funcid, target_list);
Review Comment:
pls use the m_md_accessor, which may the cached.
```
// convert func_exp -> funcid to FuncMdId(), just create a `CMDIdGPDB`
const IMDFunction *md_func =
md_accessor->RetrieveFunc(tvf_node->FuncMdId());
IMDFunction->GetResultTypeMdid() // check the RECORDID
List *arg_types = gpdb::GetFuncArgTypes(funcexpr->funcid);
... do the logic
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
