This is an automated email from the ASF dual-hosted git repository. yjhjstz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit 029ac9e79c1ade4804240762cccd3465bae4082d Author: Divyesh Vanjare <[email protected]> AuthorDate: Fri Aug 19 17:44:02 2022 -0700 Resolve tablecmd fixme for external part check We have these checks as part of ATPrepCmd for individual AT commands, These checks allow AT on external partitions iff ATT_FOREIGN_TABLE is permitted For AT_SetDistributedBy, we only allow ATT_TABLE, so external partitions would always error out based on this check Added test for this behavior --- src/backend/commands/tablecmds.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index ba85d6324d..fffb0c35a2 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -5563,9 +5563,6 @@ ATPrepCmd(List **wqueue, Relation rel, AlterTableCmd *cmd, DistributedBy *ldistro; GpPolicy *policy; - // GPDB_12_MERGE_FIXME: is this still needed? - //ATExternalPartitionCheck(cmd->subtype, rel, recursing); - Assert(IsA(cmd->def, List)); /* The distributeby clause is the second element of cmd->def */ ldistro = (DistributedBy *) lsecond((List *)cmd->def); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
