gfphoenix78 commented on code in PR #798:
URL: https://github.com/apache/cloudberry/pull/798#discussion_r1899469312
##########
src/backend/commands/dirtablecmds.c:
##########
@@ -135,7 +135,24 @@ CreateDirectoryTable(CreateDirectoryTableStmt *stmt, Oid
relId)
relFileNode.spcNode = spcId;
relFileNode.dbNode = MyDatabaseId;
relFileNode.relNode = pg_class_tuple->relfilenode;
- dirTablePath = UFileFormatPathName(&relFileNode);
+ if (stmt->location)
Review Comment:
The integer is used to represent a folder for database by the oid. We'd
better to avoid this conflict, i.e. disallowed to use a number as location name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For additional commands, e-mail: commits-h...@cloudberry.apache.org
