This is an automated email from the ASF dual-hosted git repository. yjhjstz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit 173864a37cb28ed8b7813678975b28de55d178e7 Author: Zhenghua Lyu <[email protected]> AuthorDate: Sun Oct 23 08:56:48 2022 +0800 Change FIXME to note in join_hash case. The case is to test some code path during parallel hash join but Greenplum does not support Postgres' parallel plan. Changes the FIXME to a NOTE. --- src/test/regress/expected/join_hash.out | 5 ++++- src/test/regress/expected/join_hash_optimizer.out | 5 ++++- src/test/regress/sql/join_hash.sql | 6 +++++- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/src/test/regress/expected/join_hash.out b/src/test/regress/expected/join_hash.out index fb32ed57f5..2a817e6972 100644 --- a/src/test/regress/expected/join_hash.out +++ b/src/test/regress/expected/join_hash.out @@ -918,9 +918,12 @@ rollback to settings; -- the hash table) -- parallel with parallel-aware hash join (hits ExecParallelHashLoadTuple and -- sts_puttuple oversized tuple cases because it's multi-batch) --- GPDB_12_MERGE_FIXME: I (Heikki) could not cajole the planner to create a +-- NOTE: I (Heikki) could not cajole the planner to create a -- plan like in upstream. I accepted the plan you get, but now this doesn't -- exercise the special code path it's supposed to. +-- Greenplum does not support parallel scan or parallel hash join now, the +-- following cases will not hit the code path is supposed to be. We leave +-- it here for maybe future wrk. savepoint settings; set max_parallel_workers_per_gather = 2; set enable_parallel_hash = on; diff --git a/src/test/regress/expected/join_hash_optimizer.out b/src/test/regress/expected/join_hash_optimizer.out index 35cb582c8e..23eaedbd6f 100644 --- a/src/test/regress/expected/join_hash_optimizer.out +++ b/src/test/regress/expected/join_hash_optimizer.out @@ -1007,9 +1007,12 @@ rollback to settings; -- the hash table) -- parallel with parallel-aware hash join (hits ExecParallelHashLoadTuple and -- sts_puttuple oversized tuple cases because it's multi-batch) --- GPDB_12_MERGE_FIXME: I (Heikki) could not cajole the planner to create a +-- NOTE: I (Heikki) could not cajole the planner to create a -- plan like in upstream. I accepted the plan you get, but now this doesn't -- exercise the special code path it's supposed to. +-- Greenplum does not support parallel scan or parallel hash join now, the +-- following cases will not hit the code path is supposed to be. We leave +-- it here for maybe future wrk. savepoint settings; set max_parallel_workers_per_gather = 2; set enable_parallel_hash = on; diff --git a/src/test/regress/sql/join_hash.sql b/src/test/regress/sql/join_hash.sql index 1e72839543..325068e9d2 100644 --- a/src/test/regress/sql/join_hash.sql +++ b/src/test/regress/sql/join_hash.sql @@ -471,10 +471,14 @@ rollback to settings; -- parallel with parallel-aware hash join (hits ExecParallelHashLoadTuple and -- sts_puttuple oversized tuple cases because it's multi-batch) --- GPDB_12_MERGE_FIXME: I (Heikki) could not cajole the planner to create a +-- NOTE: I (Heikki) could not cajole the planner to create a -- plan like in upstream. I accepted the plan you get, but now this doesn't -- exercise the special code path it's supposed to. +-- Greenplum does not support parallel scan or parallel hash join now, the +-- following cases will not hit the code path is supposed to be. We leave +-- it here for maybe future wrk. + savepoint settings; set max_parallel_workers_per_gather = 2; set enable_parallel_hash = on; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
