my-ship-it commented on code in PR #853:
URL: https://github.com/apache/cloudberry/pull/853#discussion_r1908235829


##########
src/backend/commands/analyze.c:
##########
@@ -722,8 +723,21 @@ do_analyze_rel(Relation onerel, VacuumParams *params,
        /*
         * Maintain information if the row of a column exceeds WIDTH_THRESHOLD
         */
-       colLargeRowIndexes = (Bitmapset **) palloc0(sizeof(Bitmapset *) * 
onerel->rd_att->natts);
-       colLargeRowLength = (double *)palloc0(sizeof(double) * 
onerel->rd_att->natts);
+       if (inh)
+       {
+               ListCell *le;
+               List* tableOIDs = find_all_inheritors(RelationGetRelid(onerel), 
AccessShareLock, NULL);

Review Comment:
   NoLock instead of AccessShareLock?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to