This is an automated email from the ASF dual-hosted git repository.

maxyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git

commit 32d33bf966bb3d55a98000c8a95b52a596ca6677
Author: Huansong Fu <[email protected]>
AuthorDate: Thu Jun 8 07:29:16 2023 -0700

    Move a FIXME from postgresql.conf.sample to guc.c
    
    The sample configuration file gets copied over to the installation
    directory which is visible to users. So it is unnecessary to show a
    FIXME message there. Move it to guc.c instead.
    
    We will be tracking the actual fix of the FIXME separately.
---
 src/backend/utils/misc/guc.c                  | 1 +
 src/backend/utils/misc/postgresql.conf.sample | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 59cfd86cec..d661ecffc8 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -3715,6 +3715,7 @@ static struct config_real ConfigureNamesReal[] =
                DEFAULT_CPU_OPERATOR_COST, 0, DBL_MAX,
                NULL, NULL, NULL
        },
+       /* GPDB_96_MERGE_FIXME: figure out the appropriate default values for 
the two parallel gucs below. */
        {
                {"parallel_tuple_cost", PGC_USERSET, QUERY_TUNING_COST,
                        gettext_noop("Sets the planner's estimate of the cost 
of "
diff --git a/src/backend/utils/misc/postgresql.conf.sample 
b/src/backend/utils/misc/postgresql.conf.sample
index 635d0ba3df..c44dc92899 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -406,8 +406,6 @@ max_prepared_transactions = 250             # can be 0 or 
more
 #cpu_tuple_cost = 0.01                 # same scale as above
 #cpu_index_tuple_cost = 0.005          # same scale as above
 #cpu_operator_cost = 0.0025            # same scale as above
-
-# GPDB_96_MERGE_FIXME: figure out the appropriate values for the parallel gucs
 #parallel_tuple_cost = 0.1             # same scale as above
 #parallel_setup_cost = 1000.0  # same scale as above
 #parallel_tuple_cost = 0.1             # same scale as above


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to