This is an automated email from the ASF dual-hosted git repository.

yjhjstz pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git

commit 696aba727e129ec2abd92489bd5f7e860a6323f7
Author: Yongtao Huang <99629139+hyongtao...@users.noreply.github.com>
AuthorDate: Mon Jul 10 16:27:43 2023 +0800

    Fix the version argument to ArgumentParser is deprecated. (#15948)
    
    The "version" argument to ArgumentParser is deprecated.
    Please refer to https://bugs.launchpad.net/yade/+bug/1134422
    
    Take a short example:
    ```
    import argparse
    parser = argparse.ArgumentParser(version='1.0')
    ```
    the error result is shown as below:
    ```
    $ python3 main.py
    Traceback (most recent call last):
      File "main.py", line 2, in <module>
        parser = argparse.ArgumentParser(version='1.0')
    TypeError: __init__() got an unexpected keyword argument 'version'
    ```
    
    **Solution**: use `parser.add_argument()` to fix it.
    
    Signed-off-by: Yongtao Huang <yongt...@vmware.com>
---
 src/backend/gporca/scripts/convert_minirepro_5_to_6.py | 3 ++-
 src/backend/gporca/scripts/get_debug_event_counters.py | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/backend/gporca/scripts/convert_minirepro_5_to_6.py 
b/src/backend/gporca/scripts/convert_minirepro_5_to_6.py
index df0fdb77a8..f32cc396ad 100755
--- a/src/backend/gporca/scripts/convert_minirepro_5_to_6.py
+++ b/src/backend/gporca/scripts/convert_minirepro_5_to_6.py
@@ -85,8 +85,9 @@ def convert_insert_statement(infile, outfile):
 
 
 def parseargs():
-       parser = argparse.ArgumentParser(description=_help, version='1.0')
+       parser = argparse.ArgumentParser(description=_help)
 
+       parser.add_argument('--version', action='version', version='1.0')
        parser.add_argument("filepath", help="Path to minirepro file")
 
        args = parser.parse_args()
diff --git a/src/backend/gporca/scripts/get_debug_event_counters.py 
b/src/backend/gporca/scripts/get_debug_event_counters.py
index b27851df1b..41a5b0ea41 100755
--- a/src/backend/gporca/scripts/get_debug_event_counters.py
+++ b/src/backend/gporca/scripts/get_debug_event_counters.py
@@ -172,8 +172,9 @@ def processLogFile(logFileLines, allruns):
 
 
 def parseargs():
-       parser = argparse.ArgumentParser(description=_help, version='1.0')
+       parser = argparse.ArgumentParser(description=_help)
 
+       parser.add_argument('--version', action='version', version='1.0')
        parser.add_argument("--logFile", default="",
                                                help="GPDB log file saved from 
a run with debug event counters enabled (default is to search "
                                                         "GPDB master log 
directory)")


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For additional commands, e-mail: commits-h...@cloudberry.apache.org

Reply via email to