This is an automated email from the ASF dual-hosted git repository.
jiaqizho pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit ba61d483185d00ef65a817a032e0a61dd5bcc56a
Author: Chris Hajas <cha...@vmware.com>
AuthorDate: Mon Feb 6 15:06:13 2023 -0800
Address CTE translation FIXMEs
When creating a table descriptor in Orca for a CTAS query, the created
table should have a RowExclusiveLock as planner does in createas.c.
---
src/backend/gporca/libgpopt/src/translate/CTranslatorDXLToExpr.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/gporca/libgpopt/src/translate/CTranslatorDXLToExpr.cpp
b/src/backend/gporca/libgpopt/src/translate/CTranslatorDXLToExpr.cpp
index 59b809e85d..92f446d285 100644
--- a/src/backend/gporca/libgpopt/src/translate/CTranslatorDXLToExpr.cpp
+++ b/src/backend/gporca/libgpopt/src/translate/CTranslatorDXLToExpr.cpp
@@ -2318,8 +2318,8 @@ CTranslatorDXLToExpr::PtabdescFromCTAS(CDXLLogicalCTAS
*pdxlopCTAS)
CTableDescriptor *ptabdesc = GPOS_NEW(m_mp) CTableDescriptor(
m_mp, mdid, CName(m_mp, &strName),
pmdrel->ConvertHashToRandom(),
rel_distr_policy, rel_storage_type,
- 0, // TODO: - Mar 5, 2014; ulExecuteAsUser
- -1, // GPDB_12_MERGE_FIXME: Extract the lockmode from CTE
+ 0, // ulExecuteAsUser, use permissions of current user
+ 3, // CTEs always use a RowExclusiveLock on the table. See
createas.c
UNASSIGNED_QUERYID);
// populate column information from the dxl table descriptor
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For additional commands, e-mail: commits-h...@cloudberry.apache.org
