This is an automated email from the ASF dual-hosted git repository. avamingli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit 76a08f8fca07c625b869aa5870fb628156238d45 Author: Adam Lee <[email protected]> AuthorDate: Mon Mar 18 15:21:10 2024 +0800 Remove a fixme of plpgsql tests It acts as expected, remove the comment fixme. --- src/test/regress/expected/plpgsql.out | 11 +++-------- src/test/regress/expected/plpgsql_optimizer.out | 11 +++-------- src/test/regress/sql/plpgsql.sql | 11 +++-------- 3 files changed, 9 insertions(+), 24 deletions(-) diff --git a/src/test/regress/expected/plpgsql.out b/src/test/regress/expected/plpgsql.out index e4dbc4d3a5..1fde463c09 100644 --- a/src/test/regress/expected/plpgsql.out +++ b/src/test/regress/expected/plpgsql.out @@ -1736,14 +1736,9 @@ insert into PField values ('PF1_1', 'should fail due to unique index'); ERROR: duplicate key value violates unique constraint "pfield_name" DETAIL: Key (name)=(PF1_1) already exists. /* - * GPDB_96_MERGE_FIXME : should these update statements trigger the error - * ERRCODE_FEATURE_NOT_SUPPORTED: function cannot execute on a QE slice because - * it accesses relation "public.wslot"? - * In Postgres, the expected behavior of these tests is to error out because - * 'WS.not.there' does not exist. - * However, in GPDB, it is unclear what the intended behavior is. - * Currently, it does not error out but has no effect, as the table is empty at - * this point in the test in GPDB + * It does not error out but has no effect, as the table is empty at this point + * in the test in GPDB. If data exist it errors out "ERROR: function cannot + * execute on a QE slice because it accesses relation "public.pfield" * Adding an ignore block for now */ --start_ignore diff --git a/src/test/regress/expected/plpgsql_optimizer.out b/src/test/regress/expected/plpgsql_optimizer.out index e72bd73c24..c04d62c1bf 100755 --- a/src/test/regress/expected/plpgsql_optimizer.out +++ b/src/test/regress/expected/plpgsql_optimizer.out @@ -1736,14 +1736,9 @@ insert into PField values ('PF1_1', 'should fail due to unique index'); ERROR: duplicate key value violates unique constraint "pfield_name" DETAIL: Key (name)=(PF1_1) already exists. /* - * GPDB_96_MERGE_FIXME : should these update statements trigger the error - * ERRCODE_FEATURE_NOT_SUPPORTED: function cannot execute on a QE slice because - * it accesses relation "public.wslot"? - * In Postgres, the expected behavior of these tests is to error out because - * 'WS.not.there' does not exist. - * However, in GPDB, it is unclear what the intended behavior is. - * Currently, it does not error out but has no effect, as the table is empty at - * this point in the test in GPDB + * It does not error out but has no effect, as the table is empty at this point + * in the test in GPDB. If data exist it errors out "ERROR: function cannot + * execute on a QE slice because it accesses relation "public.pfield" * Adding an ignore block for now */ --start_ignore diff --git a/src/test/regress/sql/plpgsql.sql b/src/test/regress/sql/plpgsql.sql index e0316ff099..2083792466 100644 --- a/src/test/regress/sql/plpgsql.sql +++ b/src/test/regress/sql/plpgsql.sql @@ -1408,14 +1408,9 @@ select * from PField_v1 where pfname = 'PF0_2' order by slotname; -- insert into PField values ('PF1_1', 'should fail due to unique index'); /* - * GPDB_96_MERGE_FIXME : should these update statements trigger the error - * ERRCODE_FEATURE_NOT_SUPPORTED: function cannot execute on a QE slice because - * it accesses relation "public.wslot"? - * In Postgres, the expected behavior of these tests is to error out because - * 'WS.not.there' does not exist. - * However, in GPDB, it is unclear what the intended behavior is. - * Currently, it does not error out but has no effect, as the table is empty at - * this point in the test in GPDB + * It does not error out but has no effect, as the table is empty at this point + * in the test in GPDB. If data exist it errors out "ERROR: function cannot + * execute on a QE slice because it accesses relation "public.pfield" * Adding an ignore block for now */ --start_ignore --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
