avamingli opened a new pull request, #913:
URL: https://github.com/apache/cloudberry/pull/913
This PR reintroduces **streaming hash aggregation** functionality to CBDB
(Cloudberry Database). While it is inspired by the implementation in GPDB, it
is not a straightforward cherry-pick due to significant differences between
GPDB and CBDB, particularly because CBDB is based on the PostgreSQL 14 kernel.
As a result, I had to make several adjustments to resolve conflicts and adapt
the code to the CBDB codebase.
For example:
The `lookup_hash_entry` function, which was modified in GPDB, has been
removed in PostgreSQL 14. I adapted the code to work with the current CBDB
implementation.
Some fault injection mechanisms from GPDB could not be ported directly due
to incompatibilities or missing dependencies in CBDB. For now, these fault
injection points have been removed to ensure that streaming hash aggregation
works correctly in CBDB. Future work will focus on reintroducing these
mechanisms once the necessary infrastructure is in place.
### **Checklist**
- [ ] Code changes reviewed and approved.
- [ ] Regression tests passed.
- [ ] Performance tests conducted for streaming hash aggregation.
- [ ] Documentation updated (if applicable).
---
This PR lays the groundwork for streaming hash aggregation in CBDB and
ensures compatibility with the PostgreSQL 14 kernel. Your feedback and review
are greatly appreciated!
---
Let me know if you need further adjustments!
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
