This is an automated email from the ASF dual-hosted git repository. maxyang pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit e18aec258961bbc52487561ead50dabbe92291a4 Author: David Kimura <[email protected]> AuthorDate: Tue Nov 7 10:22:28 2023 -0800 Remove 'hack' from comments from commit 6e2c664e (#16706) --- src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp | 4 ++-- src/backend/gporca/libgpos/src/common/clibwrapper.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp b/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp index 0f3234253f..864d284e91 100644 --- a/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp +++ b/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp @@ -5592,8 +5592,8 @@ CTranslatorDXLToPlStmt::TranslateDXLProjList( target_entry->resorigtbl = pteOriginal->resorigtbl; target_entry->resorigcol = pteOriginal->resorigcol; - // Hack! ORCA represents strings using wide characters. That - // can require converting from multibyte characters using + // ORCA represents strings using wide characters. That can + // require converting from multibyte characters using // vswprintf(). However, vswprintf() is dependent on the system // locale which is set at the database level. When that locale // cannot interpret the string correctly, it fails. ORCA diff --git a/src/backend/gporca/libgpos/src/common/clibwrapper.cpp b/src/backend/gporca/libgpos/src/common/clibwrapper.cpp index 33935edd94..6dbfc5f35d 100644 --- a/src/backend/gporca/libgpos/src/common/clibwrapper.cpp +++ b/src/backend/gporca/libgpos/src/common/clibwrapper.cpp @@ -359,7 +359,7 @@ gpos::clib::Vswprintf(WCHAR *wcstr, SIZE_T max_len, const WCHAR *format, // Invalid multibyte character encountered. This can happen if the byte sequence does not // match with the server encoding. // - // Hack! Rather than fail/fall-back here, ORCA uses a generic "UNKNOWN" + // Rather than fail/fall-back here, ORCA uses a generic "UNKNOWN" // string. During DXL to PlStmt translation this will be translated // back using the original query tree (see TranslateDXLProjList) res = swprintf(wcstr, max_len, format, "UNKNOWN"); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
