gongxun0928 commented on code in PR #1056:
URL: https://github.com/apache/cloudberry/pull/1056#discussion_r2053276317


##########
src/backend/commands/explain.c:
##########
@@ -4265,8 +4265,15 @@ show_hashagg_info(AggState *aggstate, ExplainState *es)
                        appendStringInfoChar(es->str, '\n');
        }
 
+       /*
+        * Greenplums outputs hash aggregate information in "Extra Text" via
+        * cdbexplainbuf, hash_agg_update_metrics() is never called on QD.
+        */
+       if (Gp_role != GP_ROLE_UTILITY || !es->analyze)

Review Comment:
   hash_agg_update_metrics() is never called on QD.
   so `Gp_role != GP_ROLE_DISPATCH`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to