tuhaihe commented on code in PR #1084: URL: https://github.com/apache/cloudberry/pull/1084#discussion_r2074676132
########## .gitmodules: ########## @@ -1,20 +1,31 @@ [submodule "gpcontrib/gpcloud/test/googletest"] path = gpcontrib/gpcloud/test/googletest url = https://github.com/google/googletest.git + # tag: release-1.8.0 Review Comment: Is the release number too old? FYI. ########## .gitmodules: ########## @@ -1,20 +1,31 @@ [submodule "gpcontrib/gpcloud/test/googletest"] path = gpcontrib/gpcloud/test/googletest url = https://github.com/google/googletest.git + # tag: release-1.8.0 + branch = 52204f78f94d7512df1f0f3bea1d47437a2c3a58 [submodule "contrib/pax_storage/src/cpp/contrib/googletest"] path = contrib/pax_storage/src/cpp/contrib/googletest url = https://github.com/google/googletest.git - branch = v1.15.x + # tag: release-1.8.0 + branch = 52204f78f94d7512df1f0f3bea1d47437a2c3a58 [submodule "contrib/pax_storage/src/cpp/contrib/tabulate"] path = contrib/pax_storage/src/cpp/contrib/tabulate url = https://github.com/p-ranav/tabulate.git + # tag: v1.3 + branch = 3a58301067bbc03da89ae5a51b3e05b7da719d38 Review Comment: v1.3 <~> 56b0b7aabdc28eb374420226f8b0db1e458295fc ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org For additional commands, e-mail: commits-h...@cloudberry.apache.org