gfphoenix78 commented on code in PR #1059:
URL: https://github.com/apache/cloudberry/pull/1059#discussion_r2079685390
##########
src/backend/executor/execMain.c:
##########
@@ -2805,7 +2806,7 @@ ExecutePlan(EState *estate,
* because that tuple slot has the wrong descriptor.)
*/
if (estate->es_junkFilter != NULL)
- slot = ExecFilterJunk(estate->es_junkFilter, slot);
+ slot =
estate->es_junkFilter->jf_execFilterJunkFunc(estate->es_junkFilter, slot);
Review Comment:
Could you hide the function pointer detail in ExecFilterJunk?
like:
```c
ExecFilterJunk() {
if (estate->es_junkFilter->jf_execFilterJunkFunc)
return estate->es_junkFilter->jf_execFilterJunkFunc(...);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
