This is an automated email from the ASF dual-hosted git repository.
gfphoenix78 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
The following commit(s) were added to refs/heads/main by this push:
new fb8685159a performance: Change the default value of pax_enable_debug
to false (#1093)
fb8685159a is described below
commit fb8685159a116939bc43fd3ff9c3cb242b15a80e
Author: Xun Gong <[email protected]>
AuthorDate: Fri May 23 23:00:31 2025 +0800
performance: Change the default value of pax_enable_debug to false (#1093)
When the default value of pax_enable_debug is true, some
debug logs will be printed by default. We need to set it
to false to avoid printing these logs.
---
contrib/pax_storage/expected/filter.out | 1 +
contrib/pax_storage/expected/statistics_bloom_filter.out | 1 +
contrib/pax_storage/sql/filter.sql | 1 +
contrib/pax_storage/sql/statistics_bloom_filter.sql | 2 +-
contrib/pax_storage/src/cpp/comm/guc.cc | 6 +++---
5 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/contrib/pax_storage/expected/filter.out
b/contrib/pax_storage/expected/filter.out
index ac72f0c359..f182c041a3 100644
--- a/contrib/pax_storage/expected/filter.out
+++ b/contrib/pax_storage/expected/filter.out
@@ -1,3 +1,4 @@
+set pax_enable_debug to on;
set pax_enable_sparse_filter = on;
create table pax_test.null_test_t(a int, b int, c text) using pax;
insert into pax_test.null_test_t(a) select null from generate_series(1,2)i;
diff --git a/contrib/pax_storage/expected/statistics_bloom_filter.out
b/contrib/pax_storage/expected/statistics_bloom_filter.out
index 9dacf52d09..bb2b4ae7c1 100644
--- a/contrib/pax_storage/expected/statistics_bloom_filter.out
+++ b/contrib/pax_storage/expected/statistics_bloom_filter.out
@@ -6,6 +6,7 @@
-- m/^LOG: Missing statistics for column: .*/
-- end_matchignore
set default_table_access_method = pax;
+set pax_enable_debug to on;
--
-- Test with small group
--
diff --git a/contrib/pax_storage/sql/filter.sql
b/contrib/pax_storage/sql/filter.sql
index 6dba1395f3..c2548f5070 100644
--- a/contrib/pax_storage/sql/filter.sql
+++ b/contrib/pax_storage/sql/filter.sql
@@ -1,3 +1,4 @@
+set pax_enable_debug to on;
set pax_enable_sparse_filter = on;
create table pax_test.null_test_t(a int, b int, c text) using pax;
diff --git a/contrib/pax_storage/sql/statistics_bloom_filter.sql
b/contrib/pax_storage/sql/statistics_bloom_filter.sql
index 9c98ddfa97..53cfbf9418 100644
--- a/contrib/pax_storage/sql/statistics_bloom_filter.sql
+++ b/contrib/pax_storage/sql/statistics_bloom_filter.sql
@@ -6,7 +6,7 @@
-- m/^LOG: Missing statistics for column: .*/
-- end_matchignore
set default_table_access_method = pax;
-
+set pax_enable_debug to on;
--
-- Test with small group
--
diff --git a/contrib/pax_storage/src/cpp/comm/guc.cc
b/contrib/pax_storage/src/cpp/comm/guc.cc
index 3968b214b2..6cdc429a3e 100644
--- a/contrib/pax_storage/src/cpp/comm/guc.cc
+++ b/contrib/pax_storage/src/cpp/comm/guc.cc
@@ -58,7 +58,7 @@ namespace pax {
#define PAX_MIN_BLOOM_FILTER_WORK_MEMORY_BYTES (1 * 1024)
#define PAX_MAX_BLOOM_FILTER_WORK_MEMORY_BYTES (INT_MAX)
-bool pax_enable_debug = true;
+bool pax_enable_debug = false;
bool pax_enable_sparse_filter = true;
bool pax_enable_row_filter = false;
int pax_scan_reuse_buffer_size = 0;
@@ -127,8 +127,8 @@ static bool CheckDefaultStorageFormat(char **newval, void
**extra,
void DefineGUCs() {
DefineCustomBoolVariable("pax_enable_debug", "enable pax debug", NULL,
- &pax::pax_enable_debug, true, PGC_USERSET, 0, NULL,
- NULL, NULL);
+ &pax::pax_enable_debug, false, PGC_USERSET,
+ GUC_GPDB_NEED_SYNC, NULL, NULL, NULL);
DefineCustomBoolVariable("pax_enable_sparse_filter",
"enable pax filter, contains min/max and bloom "
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
