This is an automated email from the ASF dual-hosted git repository.
gfphoenix78 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
The following commit(s) were added to refs/heads/main by this push:
new 114956860b Fix unstable case of auto_explain. (#1127)
114956860b is described below
commit 114956860ba86154aa331eeb8982e828a6ac9daf
Author: DongxiaoSong <[email protected]>
AuthorDate: Thu May 29 12:37:43 2025 +0800
Fix unstable case of auto_explain. (#1127)
This case rely on sql "SELECT relname FROM pg_class WHERE
relname='pg_class';" could finish in 1ms.
Debug build for some platform may fail. Add pg_sleep for sql to make sure
running more than 1s.
Signed-off-by: Dongxiao Song <[email protected]>
---
contrib/auto_explain/expected/auto_explain.out | 18 +++++++++---------
.../auto_explain/expected/auto_explain_optimizer.out | 18 +++++++++---------
contrib/auto_explain/sql/auto_explain.sql | 4 ++--
3 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/contrib/auto_explain/expected/auto_explain.out
b/contrib/auto_explain/expected/auto_explain.out
index b210aa170e..0560cfb25b 100644
--- a/contrib/auto_explain/expected/auto_explain.out
+++ b/contrib/auto_explain/expected/auto_explain.out
@@ -68,8 +68,8 @@ Memory used: 128000kB
1002001
(1 row)
-SET auto_explain.log_min_duration = 1;
-LOG: statement: SET auto_explain.log_min_duration = 1;
+SET auto_explain.log_min_duration = 1000;
+LOG: statement: SET auto_explain.log_min_duration = 1000;
SET auto_explain.log_triggers = FALSE;
LOG: statement: SET auto_explain.log_triggers = FALSE;
SET auto_explain.log_verbose = TRUE;
@@ -83,12 +83,12 @@ LOG: statement: SELECT relname FROM pg_class WHERE
relname='pg_class';
(1 row)
-- this select should also dump plan, since it takes too much time to run
-SELECT count(*) FROM auto_explain_test.t1, auto_explain_test.t2;
-LOG: statement: SELECT count(*) FROM auto_explain_test.t1,
auto_explain_test.t2;
+SELECT count(*), pg_sleep(1) FROM auto_explain_test.t1, auto_explain_test.t2;
+LOG: statement: SELECT count(*), pg_sleep(1) FROM auto_explain_test.t1,
auto_explain_test.t2;
LOG: duration: 208.523 ms plan:
-Query Text: SELECT count(*) FROM auto_explain_test.t1, auto_explain_test.t2;
+Query Text: SELECT count(*), pg_sleep(1) FROM auto_explain_test.t1,
auto_explain_test.t2;
Finalize Aggregate (cost=35148.64..35148.65 rows=1 width=8) (actual rows=1
loops=1)
- Output: count(*)
+ Output: count(*), pg_sleep('1'::double precision)
-> Gather Motion 3:1 (slice1; segments: 3) (cost=35148.61..35148.64
rows=1 width=8) (actual rows=3 loops=1)
Output: (PARTIAL count(*))
-> Partial Aggregate (cost=35148.61..35148.62 rows=1 width=8)
(actual rows=1 loops=1)
@@ -106,9 +106,9 @@ Settings: enable_nestloop = 'on', optimizer = 'off'
(slice1) Executor memory: 152K bytes avg x 3 workers, 152K bytes max
(seg0).
(slice2) Executor memory: 42K bytes avg x 3 workers, 42K bytes max (seg0).
Memory used: 128000kB
- count
----------
- 1002001
+ count | pg_sleep
+---------+----------
+ 1002001 |
(1 row)
-- clean jobs
diff --git a/contrib/auto_explain/expected/auto_explain_optimizer.out
b/contrib/auto_explain/expected/auto_explain_optimizer.out
index abc1d6e827..e1d3e334d9 100644
--- a/contrib/auto_explain/expected/auto_explain_optimizer.out
+++ b/contrib/auto_explain/expected/auto_explain_optimizer.out
@@ -67,8 +67,8 @@ Memory used: 128000kB
1002001
(1 row)
-SET auto_explain.log_min_duration = 1;
-LOG: statement: SET auto_explain.log_min_duration = 1;
+SET auto_explain.log_min_duration = 1000;
+LOG: statement: SET auto_explain.log_min_duration = 1000;
SET auto_explain.log_triggers = FALSE;
LOG: statement: SET auto_explain.log_triggers = FALSE;
SET auto_explain.log_verbose = TRUE;
@@ -83,12 +83,12 @@ LOG: statement: SELECT relname FROM pg_class WHERE
relname='pg_class';
(1 row)
-- this select should also dump plan, since it takes too much time to run
-SELECT count(*) FROM auto_explain_test.t1, auto_explain_test.t2;
-LOG: statement: SELECT count(*) FROM auto_explain_test.t1,
auto_explain_test.t2;
+SELECT count(*), pg_sleep(1) FROM auto_explain_test.t1, auto_explain_test.t2;
+LOG: statement: SELECT count(*), pg_sleep(1) FROM auto_explain_test.t1,
auto_explain_test.t2;
LOG: duration: 180.126 ms plan:
-Query Text: SELECT count(*) FROM auto_explain_test.t1, auto_explain_test.t2;
+Query Text: SELECT count(*), pg_sleep(1) FROM auto_explain_test.t1,
auto_explain_test.t2;
Finalize Aggregate (cost=0.00..1326086.34 rows=1 width=8) (actual rows=1
loops=1)
- Output: count(*)
+ Output: count(*), pg_sleep('1'::double precision)
-> Gather Motion 3:1 (slice1; segments: 3) (cost=0.00..1326086.34 rows=1
width=8) (actual rows=3 loops=1)
Output: (PARTIAL count(*))
-> Partial Aggregate (cost=0.00..1326086.34 rows=1 width=8) (actual
rows=1 loops=1)
@@ -103,9 +103,9 @@ Settings: enable_nestloop = 'on'
(slice1) Executor memory: 119K bytes avg x 3 workers, 119K bytes max
(seg0).
(slice2) Executor memory: 42K bytes avg x 3 workers, 42K bytes max (seg0).
Memory used: 128000kB
- count
----------
- 1002001
+ count | pg_sleep
+---------+----------
+ 1002001 |
(1 row)
-- clean jobs
diff --git a/contrib/auto_explain/sql/auto_explain.sql
b/contrib/auto_explain/sql/auto_explain.sql
index 37e312be52..51e3d3c491 100644
--- a/contrib/auto_explain/sql/auto_explain.sql
+++ b/contrib/auto_explain/sql/auto_explain.sql
@@ -25,14 +25,14 @@ SET auto_explain.log_verbose = FALSE;
SELECT relname FROM pg_class WHERE relname='pg_class';
SELECT count(*) FROM auto_explain_test.t1, auto_explain_test.t2;
-SET auto_explain.log_min_duration = 1;
+SET auto_explain.log_min_duration = 1000;
SET auto_explain.log_triggers = FALSE;
SET auto_explain.log_verbose = TRUE;
-- this select should not dump execution plan
SELECT relname FROM pg_class WHERE relname='pg_class';
-- this select should also dump plan, since it takes too much time to run
-SELECT count(*) FROM auto_explain_test.t1, auto_explain_test.t2;
+SELECT count(*), pg_sleep(1) FROM auto_explain_test.t1, auto_explain_test.t2;
-- clean jobs
DROP TABLE auto_explain_test.t1;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
