tuhaihe commented on code in PR #13:
URL:
https://github.com/apache/cloudberry-devops-release/pull/13#discussion_r2149603840
##########
.github/workflows/docker-cbdb-test-containers.yml:
##########
@@ -144,8 +147,8 @@ jobs:
type=gha,scope=docker-cbdb-test-${{ matrix.platform }}
# Tag with both latest and version-specific tags
tags: |
- apache/incubator-cloudberry:cbdb-test-${{ matrix.platform }}-latest
- apache/incubator-cloudberry:cbdb-test-${{ matrix.platform }}-${{
steps.version.outputs.BUILD_DATE }}-${{ steps.version.outputs.SHA_SHORT }}
+ ghcr.io/${{ github.repository }}:cbdb-test-${{ matrix.platform
}}-latest
+ ghcr.io/${{ github.repository }}:cbdb-test-${{ matrix.platform
}}-${{ steps.version.outputs.BUILD_DATE }}-${{ steps.version.outputs.SHA_SHORT
}}
Review Comment:
No need to change them here?
##########
.github/workflows/docker-cbdb-build-containers.yml:
##########
@@ -103,17 +104,17 @@ jobs:
- 'images/docker/cbdb/build/rocky8/**'
rocky9:
- 'images/docker/cbdb/build/rocky9/**'
+ ubuntu22.04:
+ - 'images/docker/cbdb/build/ubuntu22.04/**'
# Set up QEMU for multi-architecture support
# This allows building ARM64 images on AMD64 infrastructure and vice
versa
- name: Set up QEMU
if: ${{ steps.platform-filter.outputs[matrix.platform] == 'true' }}
uses: docker/setup-qemu-action@v3
- # Login to DockerHub for pushing images
- # Requires DOCKERHUB_USER and DOCKERHUB_TOKEN secrets to be set
- - name: Login to Docker Hub
- if: ${{ steps.platform-filter.outputs[matrix.platform] == 'true' }}
+ # Login to GitHub Container Registry for pushing images
+ - name: Login to GitHub Container Registry
Review Comment:
Still use the Docker hub instead of GitHub to push the images in the
production env. So no need to change these lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For additional commands, e-mail: commits-h...@cloudberry.apache.org
