tuhaihe commented on code in PR #1064:
URL: https://github.com/apache/cloudberry/pull/1064#discussion_r2176334847
##########
configure.ac:
##########
@@ -1749,6 +1765,13 @@ fi
AC_SUBST(LDAP_LIBS_FE)
AC_SUBST(LDAP_LIBS_BE)
+# for contrib/pax_storage
+if test "$enable_pax" = yes; then
+ if test "$enable_shared_postgres_backend" = no; then
+ AC_MSG_ERROR([pax support requires --enable-shared-postgres-backend])
Review Comment:
```suggestion
AC_MSG_ERROR([PAX support requires --enable-shared-postgres-backend])
```
##########
configure.ac:
##########
@@ -880,6 +880,22 @@ AS_IF([test "$enable_shared_postgres_backend" = yes ],
CXXFLAGS="$CXXFLAGS -fPIC "
]) # fi
+#
+# --enable-link-postgres-with-shared enables linking postgres with shared
library libpostgres.so
+#
+PGAC_ARG_BOOL(enable, link-postgres-with-shared, no, [build Cloudberry using
the shared library libpostgres.so],
+ [AC_DEFINE([USE_LINK_POSTGRES_WITH_SHARED], 1,
+ [Define to 1 to build postgres using the
shared library libpostgres.so (--enable-link-postgres-with-shared)])])
+AC_MSG_RESULT([checking whether to build postgres using the shared library
libpostgres.so... $enable_link_postgres_with_shared])
Review Comment:
```suggestion
AC_MSG_RESULT([checking whether to build Cloudberry using the shared library
libpostgres.so... $enable_link_postgres_with_shared])
```
##########
configure.ac:
##########
@@ -880,6 +880,22 @@ AS_IF([test "$enable_shared_postgres_backend" = yes ],
CXXFLAGS="$CXXFLAGS -fPIC "
]) # fi
+#
+# --enable-link-postgres-with-shared enables linking postgres with shared
library libpostgres.so
+#
+PGAC_ARG_BOOL(enable, link-postgres-with-shared, no, [build Cloudberry using
the shared library libpostgres.so],
+ [AC_DEFINE([USE_LINK_POSTGRES_WITH_SHARED], 1,
+ [Define to 1 to build postgres using the
shared library libpostgres.so (--enable-link-postgres-with-shared)])])
Review Comment:
```suggestion
[Define to 1 to build Cloudberry using the
shared library libpostgres.so (--enable-link-postgres-with-shared)])])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
