ZTE-EBASE commented on code in PR #1176:
URL: https://github.com/apache/cloudberry/pull/1176#discussion_r2188870960


##########
src/bin/pg_dump/pg_dump.h:
##########
@@ -341,6 +341,7 @@ typedef struct _tableInfo
        bool            dummy_view;             /* view's real definition must 
be postponed */
        bool            postponed_def;  /* matview must be postponed into 
post-data */
        bool            ispartition;    /* is table a partition? */
+       bool        unsafe_partitions;  /* is it an unsafe partitioned table? */

Review Comment:
   ok!



##########
src/bin/pg_dump/pg_dump.c:
##########
@@ -2808,6 +2847,7 @@ dumpTableData(Archive *fout, const TableDataInfo *tdinfo)
                                                                           
.owner = tbinfo->rolname,
                                                                           
.description = "TABLE DATA",
                                                                           
.section = SECTION_DATA,
+                                                                          
.createStmt = tdDefn,

Review Comment:
   Certainly! I'm not very familiar with this test file – could you give me 
some suggestions? I'd like to understand how to compile and run these tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to